forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Testing Toolkit v1 PR Template (ethereum#536)
* dev: add: pull request template
- Loading branch information
1 parent
54f97b8
commit bf39845
Showing
2 changed files
with
44 additions
and
23 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Description | ||
|
||
Please provide a detailed description of what was done in this PR | ||
|
||
# Changes | ||
|
||
- [ ] Bugfix (non-breaking change that solves an issue) | ||
- [ ] Hotfix (change that solves an urgent issue, and requires immediate attention) | ||
- [ ] New feature (non-breaking change that adds functionality) | ||
- [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality) | ||
|
||
# Breaking changes | ||
|
||
Please complete this section if any breaking changes have been made, otherwise delete it | ||
|
||
# Checklist | ||
|
||
- [ ] I have added at least 2 reviewer or the whole pos-v1 team | ||
- [ ] I have added sufficient documentation in code | ||
- [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply | ||
|
||
# Cross repository changes | ||
|
||
- [ ] This PR requires changes to heimdall | ||
- In case link the PR here: | ||
- [ ] This PR requires changes to matic-cli | ||
- In case link the PR here: | ||
|
||
## Testing | ||
|
||
- [ ] I have added unit tests | ||
- [ ] I have added tests to CI | ||
- [ ] I have tested this code manually on local environment | ||
- [ ] I have tested this code manually on remote devnet using express-cli | ||
- [ ] I have tested this code manually on mumbai | ||
- [ ] I have created new e2e tests into express-cli | ||
|
||
### Manual tests | ||
|
||
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it | ||
|
||
# Additional comments | ||
|
||
Please post additional comments in this section if you have them, otherwise delete it |