Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing guidelines #679

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

wardoost
Copy link
Contributor

@wardoost wardoost commented Oct 15, 2019

Closes #505

@streamich We might want to only allow squash merging in the settings of this github repository? This will lead to a cleaner project history because we would only have 1 commit for each PR.

@wardoost wardoost changed the title Add contributing guidelines docs: add contributing guidelines Oct 15, 2019
@Belco90
Copy link
Contributor

Belco90 commented Oct 15, 2019

Oh wow, this is fantastic 💯

Actually, the steps you mentioned in Creating a new hook section is what I wanted to check with Danger JS, so if you add a new hook it automatically checks there are corresponding story and test files at least (but didn't have time to finish that, I hope this week 🤞)

About only allowing squashing merges, I like that idea to improve conventional commits and semantic releases (we could even use semantic-pull-requests)

@wardoost wardoost merged commit 9e4ad43 into master Oct 15, 2019
@wardoost wardoost deleted the contributing-guidelines branch October 15, 2019 22:24
@wardoost wardoost restored the contributing-guidelines branch October 16, 2019 08:13
@streamich
Copy link
Owner

🎉 This PR is included in version 12.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] add CONTRIBUTING.md
3 participants