Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useLockBodyScroll doesn't work in iframe #550

Closed
Kosai106 opened this issue Aug 22, 2019 · 2 comments · Fixed by #561
Closed

useLockBodyScroll doesn't work in iframe #550

Kosai106 opened this issue Aug 22, 2019 · 2 comments · Fixed by #561
Assignees
@xobotyi
Labels
bug Something isn't working released

Comments

@Kosai106
Copy link

What is the current behavior?

As the title suggests, the useLockBodyScroll hook doesn't appear to have any effect inside of iframes.

CodeSandbox

A little about versions:

  • OS: macOS Mojave 10.14.6
  • Browser: Google Chrome version 76.0.3809.100 (Official Build) (64-bit)
  • React: ^16.8.2
  • react-use: ^8.1.2 and 11.0.0 was tested.
@xobotyi xobotyi added the bug Something isn't working label Aug 22, 2019
@xobotyi xobotyi self-assigned this Aug 22, 2019
@xobotyi
Copy link
Contributor

xobotyi commented Aug 22, 2019

I'll investigate

xobotyi added a commit that referenced this issue Aug 23, 2019
@xobotyi
fix: #550
c9bb418
xobotyi added a commit that referenced this issue Aug 24, 2019
@xobotyi
fix: #550
a2912c5
xobotyi added a commit that referenced this issue Aug 25, 2019
@xobotyi
fix: #550
e9691af
@xobotyi xobotyi mentioned this issue Aug 25, 2019
Merged
xobotyi added a commit that referenced this issue Aug 25, 2019
@xobotyi
fix: #550
2617d74
streamich pushed a commit that referenced this issue Aug 25, 2019
@semantic-release-bot
chore(release): 11.1.1 [skip ci]
c7e9ea0 
## [11.1.1](v11.1.0...v11.1.1) (2019-08-25)

### Bug Fixes

* [#550](#550) ([2617d74](2617d74))
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xobotyi xobotyi

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make useLockBodyScroll support iframes streamich/react-use
3 participants
@xobotyi @Kosai106 @streamich