Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve relative symlinks to the current directory #1079

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

kylecarbs
Copy link
Contributor

Fixes #725.

Symlinks are intended to be stored as relative paths to their target file.

@kylecarbs
Copy link
Contributor Author

Fixed up the formatting. It should be good now!

turikhay added a commit to turikhay/memfs-relative-symlinks that referenced this pull request Dec 13, 2024
Fixes streamich#725.

Symlinks are intended to be stored as relative
paths to their target file.
@kylecarbs
Copy link
Contributor Author

@streamich anything necessary for me to change before merge?

@G-Rath G-Rath merged commit 63e3873 into streamich:master Dec 22, 2024
10 checks passed
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 22, 2024

Nope, just needed a reminder 😁

github-actions bot pushed a commit that referenced this pull request Dec 22, 2024
## [4.15.1](v4.15.0...v4.15.1) (2024-12-22)

### Bug Fixes

* resolve relative symlinks to the current directory ([#1079](#1079)) ([63e3873](63e3873)), closes [#725](#725)
Copy link

🎉 This PR is included in version 4.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kylecarbs
Copy link
Contributor Author

Amazing, thanks for the speediness in a new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative symlinks are created relative to the current directory
2 participants