Fix up clippy errors from nightly on macos and linux targets #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added
Unsafe-Proposed
lopopolo
commented
Feb 2, 2025
| @@ -89,7 +89,7 @@ mod openwrt { | |||
| } | |||
| } | |||
|
|
|||
| timezone.ok_or_else(|| crate::GetTimezoneError::OsError) | |||
| timezone.ok_or(crate::GetTimezoneError::OsError) | |||
There was a problem hiding this comment.
crate::GetTimezoneError::OsError is Copy which is why clippy says the closure is not needed.
lopopolo
commented
Feb 2, 2025
| @@ -119,8 +122,8 @@ mod string_ref { | |||
| length, | |||
| }; | |||
|
|
|||
| // SAFETY: `StringRef` is only ever created with a valid `CFStringRef`. | |||
There was a problem hiding this comment.
clippy::undocumented_unsafe_blocks wants the SAFETY comment on the block itself, not inside of it.
This was referenced Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no code changes in the unsafe macos bits, just shuffling some comments around to make the linter happy. I've included the additional safety context from #147 (comment).
This should fix the failing builds on main.