Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle jd-client config error #987

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Handle jd-client config error #987

merged 1 commit into from
Jun 26, 2024

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Jun 20, 2024 •
edited by plebhash
Loading

resolves #863

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

🐰Bencher

ReportWed, June 26, 2024 at 11:16:05 UTC
ProjectStratum v2 (SRI)
Branch987/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,548.90 (-5.17%)7,364.30 (88.93%)
client-submit-serialize-deserialize✅ (view plot)7,495.40 (-4.21%)8,343.41 (89.84%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,065.50 (-3.92%)8,853.77 (91.10%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)912.62 (+1.39%)929.74 (98.16%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)693.82 (-0.45%)717.45 (96.71%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)245.63 (-1.00%)255.03 (96.31%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)158.24 (+0.65%)162.40 (97.44%)
client-sv1-get-submit✅ (view plot)6,349.80 (-4.85%)7,147.08 (88.84%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)279.09 (+0.21%)290.85 (95.96%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)768.87 (+2.71%)779.42 (98.65%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)615.48 (+0.18%)637.15 (96.60%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)201.87 (-2.23%)219.55 (91.95%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

🐰Bencher

ReportWed, June 26, 2024 at 11:16:03 UTC
ProjectStratum v2 (SRI)
Branch2024-06-20-JDC-config-error-log
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.90 (+0.74%)45.25 (99.21%)
client_sv2_handle_message_mining✅ (view plot)77.26 (+5.87%)80.56 (95.91%)
client_sv2_mining_message_submit_standard✅ (view plot)14.65 (-0.04%)14.69 (99.69%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)247.58 (-6.27%)284.06 (87.16%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)606.62 (+2.04%)627.82 (96.62%)
client_sv2_open_channel✅ (view plot)164.24 (-0.79%)171.19 (95.94%)
client_sv2_open_channel_serialize✅ (view plot)279.31 (-1.39%)293.00 (95.33%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)371.80 (-1.86%)425.12 (87.46%)
client_sv2_setup_connection✅ (view plot)167.17 (+1.69%)175.16 (95.44%)
client_sv2_setup_connection_serialize✅ (view plot)472.08 (-0.52%)504.77 (93.52%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)966.62 (-0.43%)1,037.98 (93.13%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

🐰Bencher

ReportWed, June 26, 2024 at 11:16:05 UTC
ProjectStratum v2 (SRI)
Branch2024-06-20-JDC-config-error-log
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_handle_authorizeRAM Accesses (accesses)🚨 (view plot | view alert)368.00 (+1.10%)367.55 (100.12%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,504.00 (+0.79%)8,724.64 (97.47%)✅ (view plot)3,746.00 (+0.15%)3,854.74 (97.18%)✅ (view plot)5,249.00 (+0.08%)5,400.71 (97.19%)✅ (view plot)7.00 (-11.71%)10.37 (67.47%)✅ (view plot)92.00 (+2.14%)94.06 (97.81%)
get_submit✅ (view plot)95,475.00 (-0.08%)96,137.00 (99.31%)✅ (view plot)59,439.00 (-0.05%)59,776.31 (99.44%)✅ (view plot)85,360.00 (-0.05%)85,833.32 (99.45%)✅ (view plot)49.00 (-10.91%)62.60 (78.28%)✅ (view plot)282.00 (-0.03%)287.66 (98.03%)
get_subscribe✅ (view plot)7,957.00 (-0.25%)8,268.26 (96.24%)✅ (view plot)2,841.00 (+0.39%)2,939.32 (96.65%)✅ (view plot)3,972.00 (+0.45%)4,099.02 (96.90%)✅ (view plot)13.00 (-19.38%)19.83 (65.54%)✅ (view plot)112.00 (-0.55%)116.90 (95.81%)
serialize_authorize✅ (view plot)12,257.00 (+0.41%)12,502.37 (98.04%)✅ (view plot)5,317.00 (+0.10%)5,425.74 (98.00%)✅ (view plot)7,412.00 (+0.06%)7,564.06 (97.99%)✅ (view plot)10.00 (-7.28%)13.35 (74.89%)✅ (view plot)137.00 (+1.04%)140.24 (97.69%)
serialize_deserialize_authorize✅ (view plot)24,554.00 (+0.34%)24,709.87 (99.37%)✅ (view plot)9,898.00 (-0.02%)10,025.45 (98.73%)✅ (view plot)13,959.00 (-0.05%)14,149.90 (98.65%)✅ (view plot)33.00 (-9.63%)41.61 (79.31%)✅ (view plot)298.00 (+1.04%)298.00 (100.00%)
serialize_deserialize_handle_authorize✅ (view plot)30,293.00 (+0.47%)30,353.38 (99.80%)✅ (view plot)12,101.00 (+0.05%)12,209.74 (99.11%)✅ (view plot)17,118.00 (+0.00%)17,279.02 (99.07%)✅ (view plot)59.00 (+0.33%)64.69 (91.20%)🚨 (view plot | view alert)368.00 (+1.10%)367.55 (100.12%)
serialize_deserialize_handle_submit✅ (view plot)126,372.00 (-0.03%)127,026.75 (99.48%)✅ (view plot)73,224.00 (-0.04%)73,617.68 (99.47%)✅ (view plot)104,947.00 (-0.04%)105,508.32 (99.47%)✅ (view plot)120.00 (-0.41%)131.20 (91.46%)✅ (view plot)595.00 (+0.03%)599.17 (99.30%)
serialize_deserialize_handle_subscribe✅ (view plot)27,457.00 (+0.01%)27,600.67 (99.48%)✅ (view plot)9,643.00 (+0.11%)9,741.32 (98.99%)✅ (view plot)13,642.00 (+0.14%)13,774.93 (99.04%)✅ (view plot)61.00 (-7.33%)73.78 (82.67%)✅ (view plot)386.00 (+0.06%)388.53 (99.35%)
serialize_deserialize_submit✅ (view plot)114,999.00 (-0.07%)115,648.79 (99.44%)✅ (view plot)68,001.00 (-0.08%)68,400.22 (99.42%)✅ (view plot)97,559.00 (-0.09%)98,146.90 (99.40%)✅ (view plot)65.00 (-6.28%)75.30 (86.32%)✅ (view plot)489.00 (+0.18%)492.37 (99.32%)
serialize_deserialize_subscribe✅ (view plot)22,888.00 (+0.06%)23,110.03 (99.04%)✅ (view plot)8,195.00 (+0.11%)8,297.00 (98.77%)✅ (view plot)11,543.00 (+0.12%)11,682.16 (98.81%)✅ (view plot)36.00 (-8.49%)44.08 (81.67%)✅ (view plot)319.00 (+0.15%)321.48 (99.23%)
serialize_submit✅ (view plot)99,792.00 (-0.10%)100,465.23 (99.33%)✅ (view plot)61,483.00 (-0.05%)61,825.66 (99.45%)✅ (view plot)88,207.00 (-0.05%)88,686.81 (99.46%)✅ (view plot)49.00 (-11.85%)62.38 (78.55%)✅ (view plot)324.00 (-0.20%)329.15 (98.44%)
serialize_subscribe✅ (view plot)11,294.00 (-0.28%)11,604.16 (97.33%)✅ (view plot)4,188.00 (+0.26%)4,286.32 (97.71%)✅ (view plot)5,829.00 (+0.29%)5,958.20 (97.83%)✅ (view plot)15.00 (-8.20%)18.95 (79.14%)✅ (view plot)154.00 (-0.77%)159.72 (96.42%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

🐰Bencher

ReportWed, June 26, 2024 at 11:16:08 UTC
ProjectStratum v2 (SRI)
Branch2024-06-20-JDC-config-error-log
Testbedsv2

🚨 23 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonEstimated Cycles (estimated cycles)🚨 (view plot | view alert)2,143.00 (+4.46%)2,132.38 (100.50%)
client_sv2_handle_message_commonInstructions (instructions)🚨 (view plot | view alert)501.00 (+6.31%)488.98 (102.46%)
client_sv2_handle_message_commonL1 Accesses (accesses)🚨 (view plot | view alert)773.00 (+5.47%)758.49 (101.91%)
client_sv2_mining_message_submit_standardInstructions (instructions)🚨 (view plot | view alert)1,778.00 (+1.60%)1,765.76 (100.69%)
client_sv2_mining_message_submit_standardL1 Accesses (accesses)🚨 (view plot | view alert)2,587.00 (+1.28%)2,578.25 (100.34%)
client_sv2_mining_message_submit_standardL2 Accesses (accesses)🚨 (view plot | view alert)25.00 (+40.16%)24.12 (103.67%)
client_sv2_mining_message_submit_standard_serializeInstructions (instructions)🚨 (view plot | view alert)4,722.00 (+0.60%)4,709.76 (100.26%)
client_sv2_mining_message_submit_standard_serializeL1 Accesses (accesses)🚨 (view plot | view alert)6,791.00 (+0.53%)6,778.13 (100.19%)
client_sv2_mining_message_submit_standard_serializeL2 Accesses (accesses)🚨 (view plot | view alert)55.00 (+15.50%)53.64 (102.53%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,613.00 (+0.65%)10,575.36 (100.36%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,440.00 (+0.63%)15,385.29 (100.36%)
client_sv2_open_channelInstructions (instructions)🚨 (view plot | view alert)1,489.00 (+1.94%)1,477.00 (100.81%)
client_sv2_open_channelL1 Accesses (accesses)🚨 (view plot | view alert)2,198.00 (+2.06%)2,177.35 (100.95%)
client_sv2_open_channel_serializeInstructions (instructions)🚨 (view plot | view alert)5,092.00 (+0.56%)5,080.00 (100.24%)
client_sv2_open_channel_serializeL1 Accesses (accesses)🚨 (view plot | view alert)7,362.00 (+0.59%)7,343.32 (100.25%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,055.00 (+0.86%)8,017.66 (100.47%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,713.00 (+0.83%)11,659.84 (100.46%)
client_sv2_setup_connectionInstructions (instructions)🚨 (view plot | view alert)1,530.00 (+1.88%)1,518.00 (100.79%)
client_sv2_setup_connectionL1 Accesses (accesses)🚨 (view plot | view alert)2,315.00 (+1.65%)2,302.59 (100.54%)
client_sv2_setup_connection_serializeInstructions (instructions)🚨 (view plot | view alert)5,991.00 (+0.47%)5,979.00 (100.20%)
client_sv2_setup_connection_serializeL1 Accesses (accesses)🚨 (view plot | view alert)8,703.00 (+0.54%)8,682.15 (100.24%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,883.00 (+0.47%)14,845.10 (100.26%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,852.00 (+0.45%)21,797.20 (100.25%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)2,143.00 (+4.46%)2,132.38 (100.50%)🚨 (view plot | view alert)501.00 (+6.31%)488.98 (102.46%)🚨 (view plot | view alert)773.00 (+5.47%)758.49 (101.91%)✅ (view plot)8.00 (+14.29%)10.76 (74.32%)✅ (view plot)38.00 (+3.62%)38.60 (98.45%)
client_sv2_handle_message_mining✅ (view plot)8,257.00 (+0.70%)8,340.31 (99.00%)✅ (view plot)2,137.00 (+0.45%)2,171.21 (98.42%)✅ (view plot)3,157.00 (+0.39%)3,215.65 (98.18%)✅ (view plot)40.00 (+3.68%)43.64 (91.66%)✅ (view plot)140.00 (+0.79%)142.05 (98.56%)
client_sv2_mining_message_submit_standard✅ (view plot)6,352.00 (+1.17%)6,393.41 (99.35%)🚨 (view plot | view alert)1,778.00 (+1.60%)1,765.76 (100.69%)🚨 (view plot | view alert)2,587.00 (+1.28%)2,578.25 (100.34%)🚨 (view plot | view alert)25.00 (+40.16%)24.12 (103.67%)✅ (view plot)104.00 (+0.14%)106.90 (97.29%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,731.00 (-0.29%)15,030.53 (98.01%)🚨 (view plot | view alert)4,722.00 (+0.60%)4,709.76 (100.26%)🚨 (view plot | view alert)6,791.00 (+0.53%)6,778.13 (100.19%)🚨 (view plot | view alert)55.00 (+15.50%)53.64 (102.53%)✅ (view plot)219.00 (-1.48%)229.90 (95.26%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,535.00 (+0.20%)27,842.70 (98.89%)🚨 (view plot | view alert)10,613.00 (+0.65%)10,575.36 (100.36%)🚨 (view plot | view alert)15,440.00 (+0.63%)15,385.29 (100.36%)✅ (view plot)88.00 (+4.85%)89.96 (97.82%)✅ (view plot)333.00 (-0.53%)345.18 (96.47%)
client_sv2_open_channel✅ (view plot)4,453.00 (-0.83%)4,609.97 (96.59%)🚨 (view plot | view alert)1,489.00 (+1.94%)1,477.00 (100.81%)🚨 (view plot | view alert)2,198.00 (+2.06%)2,177.35 (100.95%)✅ (view plot)10.00 (-16.16%)15.21 (65.75%)✅ (view plot)63.00 (-3.16%)68.17 (92.41%)
client_sv2_open_channel_serialize✅ (view plot)14,042.00 (-1.18%)14,463.96 (97.08%)🚨 (view plot | view alert)5,092.00 (+0.56%)5,080.00 (100.24%)🚨 (view plot | view alert)7,362.00 (+0.59%)7,343.32 (100.25%)✅ (view plot)41.00 (+9.63%)42.28 (96.98%)✅ (view plot)185.00 (-3.43%)199.08 (92.93%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,593.00 (-0.20%)23,019.49 (98.15%)🚨 (view plot | view alert)8,055.00 (+0.86%)8,017.66 (100.47%)🚨 (view plot | view alert)11,713.00 (+0.83%)11,659.84 (100.46%)✅ (view plot)83.00 (+12.60%)83.25 (99.69%)✅ (view plot)299.00 (-1.76%)314.96 (94.93%)
client_sv2_setup_connection✅ (view plot)4,725.00 (+0.57%)4,765.33 (99.15%)🚨 (view plot | view alert)1,530.00 (+1.88%)1,518.00 (100.79%)🚨 (view plot | view alert)2,315.00 (+1.65%)2,302.59 (100.54%)✅ (view plot)13.00 (+40.47%)14.11 (92.15%)✅ (view plot)67.00 (-1.23%)69.67 (96.17%)
client_sv2_setup_connection_serialize✅ (view plot)15,978.00 (-1.70%)16,508.67 (96.79%)🚨 (view plot | view alert)5,991.00 (+0.47%)5,979.00 (100.20%)🚨 (view plot | view alert)8,703.00 (+0.54%)8,682.15 (100.24%)✅ (view plot)48.00 (+7.19%)49.42 (97.12%)✅ (view plot)201.00 (-4.60%)218.24 (92.10%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,452.00 (-0.22%)35,746.59 (99.18%)🚨 (view plot | view alert)14,883.00 (+0.47%)14,845.10 (100.26%)🚨 (view plot | view alert)21,852.00 (+0.45%)21,797.20 (100.25%)✅ (view plot)109.00 (+9.00%)113.57 (95.97%)✅ (view plot)373.00 (-1.67%)385.03 (96.88%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash
Copy link
Collaborator

thanks @jbesraa

we have a WIP refactor PR that touches this part of the code #937

@rrybarczyk is working on some adjustments via plebhash#61

I suggest we revert #987 to draft and wait until #937 is merged

@jbesraa
Copy link
Contributor Author

jbesraa commented Jun 20, 2024

thanks @jbesraa

we have a WIP refactor PR that touches this part of the code #937

@rrybarczyk is working on some adjustments via plebhash#61

I suggest we revert #987 to draft and wait until #937 is merged

Hm, While #937 looks promising I would not block this PR. #937 will take much longer to be reviewed and approved. This PR would be very beneficial in terms of error handling and can be a quick win.

CC @Sjors and @GitGab19 as they opened the original issue

@plebhash
Copy link
Collaborator

thanks @jbesraa
we have a WIP refactor PR that touches this part of the code #937
@rrybarczyk is working on some adjustments via plebhash#61
I suggest we revert #987 to draft and wait until #937 is merged

Hm, While #937 looks promising I would not block this PR. #937 will take much longer to be reviewed and approved. This PR would be very beneficial in terms of error handling and can be a quick win.

CC @Sjors and @GitGab19 as they opened the original issue

ok sounds good, I'll rebase #937 after we merge this, and I can coordinate with @rrybarczyk so she plebhash#61 follows along

Shourya742
Shourya742 reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

roles/jd-client/src/lib/job_declarator/mod.rs Outdated
Comment on lines 100 to 108
match SetupConnectionHandler::setup(&mut receiver, &mut sender, proxy_address).await {
Ok(_) => {}
Err(e) => {
error!("Error setting up connection: {:?}", e);
return Err(Error::ConnectionSetup);
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Ok case doesn't do anything, using if let is cleaner and makes the code easier to read.

Suggested change
match SetupConnectionHandler::setup(&mut receiver, &mut sender, proxy_address).await {
Ok(_) => {}
Err(e) => {
error!("Error setting up connection: {:?}", e);
return Err(Error::ConnectionSetup);
}
};
if let Err(e) = SetupConnectionHandler::setup(&mut receiver, &mut sender, proxy_address).await {
error!("Error setting up connection: {:?}", e);
return Err(Error::ConnectionSetup);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point. I left the match as is and moved the success log into the ok arm. thank you

@jbesraa jbesraa force-pushed the 2024-06-20-JDC-config-error-log branch from 7d99668 to 8fd1876 Compare June 21, 2024 11:54
@plebhash plebhash mentioned this pull request Jun 21, 2024
Merged
Shourya742
Shourya742 approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bcbf6a0

@rrybarczyk
Copy link
Collaborator

rrybarczyk commented Jun 23, 2024 •
edited
Loading

thanks @jbesraa

we have a WIP refactor PR that touches this part of the code #937

@rrybarczyk is working on some adjustments via plebhash#61

I suggest we revert #987 to draft and wait until #937 is merged

I think all config/args in the roles should be refactored as there is a lot of duplicate logic/logic that is in the wrong place. I did not end up including this refactor in the review for @plebhash's #813 PR because it started to feel out of scope. I think an immediate fix to make sure the JD config is properly configured is fine if we are time-pressed on this, but if it is not pressing, let's address all of this logic in a single issue/PR. It will fall into the "roles refactor" category.

See #997.

@rrybarczyk rrybarczyk mentioned this pull request Jun 23, 2024
Closed
@jbesraa
Copy link
Contributor Author

jbesraa commented Jun 24, 2024

@rrybarczyk I dont think its time pressed, it is part of the 1.0.2 milestone tho.
The issue(s) you mentioned includes a good a mount of refactoring and would take I think more time to be merged while this can be a small quick win(to the users)

@pavlenex pavlenex linked an issue Jun 25, 2024 that may be closed by this pull request
JDC is not logging any error on wrong TP configuration #863
Closed
@plebhash
Copy link
Collaborator

as discussed on the call, let's avoid fixing the unwraps here

let's keep PRs as atomic as possible so coordination with #813 is easier

@jbesraa jbesraa force-pushed the 2024-06-20-JDC-config-error-log branch from 8fd1876 to 9cfaebd Compare June 26, 2024 11:12
@jbesraa
Copy link
Contributor Author

jbesraa commented Jun 26, 2024

Deleted unrelated commit

@plebhash plebhash merged commit ae76f93 into stratum-mining:dev Jun 26, 2024
13 checks passed
@plebhash plebhash mentioned this pull request Jun 26, 2024
Merged
@plebhash plebhash mentioned this pull request Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shourya742 Shourya742 Shourya742 approved these changes

@plebhash plebhash plebhash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JDC is not logging any error on wrong TP configuration
4 participants
@jbesraa @plebhash @rrybarczyk @Shourya742