Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old #935

Closed
wants to merge 1 commit into from
Closed

old #935

wants to merge 1 commit into from

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented May 26, 2024

No description provided.

Copy link
Contributor

github-actions bot commented May 26, 2024

🐰Bencher

ReportSun, May 26, 2024 at 23:43:39 UTC
ProjectStratum v2 (SRI)
Branchstandardize-cli
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.52 (-0.08%)45.24 (98.41%)
client_sv2_handle_message_mining✅ (view plot)74.81 (+2.75%)80.84 (92.54%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.16%)14.69 (99.60%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)261.08 (-1.26%)284.14 (91.88%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)592.84 (-0.11%)624.20 (94.98%)
client_sv2_open_channel✅ (view plot)167.47 (+1.02%)171.87 (97.44%)
client_sv2_open_channel_serialize✅ (view plot)279.38 (-1.43%)293.19 (95.29%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)375.06 (-0.23%)401.62 (93.39%)
client_sv2_setup_connection✅ (view plot)165.29 (+0.54%)175.16 (94.36%)
client_sv2_setup_connection_serialize✅ (view plot)463.91 (-2.04%)502.06 (92.40%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)963.27 (-0.88%)1,038.24 (92.78%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 26, 2024

🐰Bencher

ReportSun, May 26, 2024 at 23:43:38 UTC
ProjectStratum v2 (SRI)
Branchstandardize-cli
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_subscribeL2 Accesses (accesses)🚨 (view plot | view alert)19.00 (+16.05%)18.98 (100.11%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,515.00 (+0.98%)8,731.82 (97.52%)✅ (view plot)3,772.00 (+0.87%)3,858.83 (97.75%)✅ (view plot)5,295.00 (+0.98%)5,406.09 (97.95%)✅ (view plot)7.00 (-12.50%)10.43 (67.08%)✅ (view plot)91.00 (+1.16%)94.05 (96.76%)
get_submit✅ (view plot)95,622.00 (+0.07%)96,169.16 (99.43%)✅ (view plot)59,522.00 (+0.09%)59,792.09 (99.55%)✅ (view plot)85,492.00 (+0.10%)85,854.90 (99.58%)✅ (view plot)59.00 (+6.74%)62.56 (94.31%)✅ (view plot)281.00 (-0.40%)287.94 (97.59%)
get_subscribe✅ (view plot)8,028.00 (+0.64%)8,282.90 (96.92%)✅ (view plot)2,848.00 (+0.68%)2,943.14 (96.77%)✅ (view plot)3,978.00 (+0.66%)4,103.68 (96.94%)✅ (view plot)19.00 (+16.89%)19.74 (96.23%)✅ (view plot)113.00 (+0.30%)117.16 (96.45%)
serialize_authorize✅ (view plot)12,336.00 (+1.09%)12,510.12 (98.61%)✅ (view plot)5,343.00 (+0.61%)5,429.83 (98.40%)✅ (view plot)7,456.00 (+0.67%)7,569.52 (98.50%)✅ (view plot)10.00 (-7.78%)13.43 (74.46%)✅ (view plot)138.00 (+1.85%)140.31 (98.35%)
serialize_deserialize_authorize✅ (view plot)24,550.00 (+0.34%)24,712.54 (99.34%)✅ (view plot)9,950.00 (+0.52%)10,029.85 (99.20%)✅ (view plot)14,050.00 (+0.61%)14,155.84 (99.25%)✅ (view plot)35.00 (-4.80%)41.72 (83.90%)✅ (view plot)295.00 (+0.07%)297.60 (99.13%)
serialize_deserialize_handle_authorize✅ (view plot)30,150.00 (+0.03%)30,337.20 (99.38%)✅ (view plot)12,127.00 (+0.27%)12,213.83 (99.29%)✅ (view plot)17,165.00 (+0.29%)17,285.13 (99.31%)✅ (view plot)63.00 (+7.31%)64.75 (97.30%)✅ (view plot)362.00 (-0.49%)366.68 (98.72%)
serialize_deserialize_handle_submit✅ (view plot)126,469.00 (+0.04%)127,059.17 (99.54%)✅ (view plot)73,307.00 (+0.08%)73,636.45 (99.55%)✅ (view plot)105,084.00 (+0.09%)105,534.64 (99.57%)✅ (view plot)126.00 (+4.68%)131.47 (95.84%)✅ (view plot)593.00 (-0.31%)599.32 (98.95%)
serialize_deserialize_handle_subscribe✅ (view plot)27,442.00 (-0.05%)27,606.61 (99.40%)✅ (view plot)9,650.00 (+0.20%)9,745.14 (99.02%)✅ (view plot)13,647.00 (+0.19%)13,779.93 (99.04%)✅ (view plot)71.00 (+7.61%)73.80 (96.21%)✅ (view plot)384.00 (-0.47%)388.52 (98.84%)
serialize_deserialize_submit✅ (view plot)115,249.00 (+0.14%)115,676.54 (99.63%)✅ (view plot)68,167.00 (+0.16%)68,416.74 (99.63%)✅ (view plot)97,834.00 (+0.19%)98,169.82 (99.66%)✅ (view plot)74.00 (+6.46%)75.16 (98.45%)✅ (view plot)487.00 (-0.22%)492.52 (98.88%)
serialize_deserialize_subscribe✅ (view plot)22,934.00 (+0.26%)23,120.72 (99.19%)✅ (view plot)8,209.00 (+0.30%)8,300.93 (98.89%)✅ (view plot)11,564.00 (+0.31%)11,687.21 (98.95%)✅ (view plot)41.00 (+3.67%)44.19 (92.79%)✅ (view plot)319.00 (+0.15%)321.64 (99.18%)
serialize_submit✅ (view plot)100,015.00 (+0.12%)100,496.01 (99.52%)✅ (view plot)61,566.00 (+0.08%)61,841.74 (99.55%)✅ (view plot)88,335.00 (+0.09%)88,708.88 (99.58%)✅ (view plot)61.00 (+9.16%)62.00 (98.39%)✅ (view plot)325.00 (+0.09%)329.42 (98.66%)
serialize_subscribe✅ (view plot)11,425.00 (+0.87%)11,617.48 (98.34%)✅ (view plot)4,195.00 (+0.46%)4,290.14 (97.78%)✅ (view plot)5,835.00 (+0.42%)5,963.06 (97.85%)🚨 (view plot | view alert)19.00 (+16.05%)18.98 (100.11%)✅ (view plot)157.00 (+1.12%)159.98 (98.14%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 26, 2024

🐰Bencher

ReportSun, May 26, 2024 at 23:43:40 UTC
ProjectStratum v2 (SRI)
Branch935/merge
Testbedsv1

🚨 2 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-authorize-serialize/client-sv1-authorize-serializeLatency (nanoseconds (ns))🚨 (view plot | view alert)257.43 (+3.86%)255.21 (100.87%)
client-sv1-get-authorize/client-sv1-get-authorizeLatency (nanoseconds (ns))🚨 (view plot | view alert)163.00 (+3.87%)160.77 (101.39%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)7,068.00 (+1.71%)7,320.05 (96.56%)
client-submit-serialize-deserialize✅ (view plot)8,040.40 (+2.14%)8,312.63 (96.73%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,608.30 (+2.01%)8,839.12 (97.39%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)880.95 (-1.79%)926.30 (95.10%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)691.22 (-0.71%)717.06 (96.40%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize🚨 (view plot | view alert)257.43 (+3.86%)255.21 (100.87%)
client-sv1-get-authorize/client-sv1-get-authorize🚨 (view plot | view alert)163.00 (+3.87%)160.77 (101.39%)
client-sv1-get-submit✅ (view plot)6,837.70 (+2.02%)7,056.66 (96.90%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)274.14 (-1.76%)292.48 (93.73%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)735.35 (-1.48%)774.97 (94.89%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)619.15 (+0.68%)637.85 (97.07%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)210.58 (+1.84%)219.77 (95.82%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 26, 2024

🐰Bencher

ReportSun, May 26, 2024 at 23:43:35 UTC
ProjectStratum v2 (SRI)
Branchstandardize-cli
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,065.00 (+0.82%)2,126.35 (97.11%)✅ (view plot)473.00 (+0.52%)486.69 (97.19%)✅ (view plot)735.00 (+0.38%)755.94 (97.23%)✅ (view plot)7.00 (+2.88%)10.15 (69.00%)✅ (view plot)37.00 (+1.02%)38.58 (95.89%)
client_sv2_handle_message_mining✅ (view plot)8,203.00 (+0.10%)8,336.95 (98.39%)✅ (view plot)2,137.00 (+0.48%)2,171.85 (98.40%)✅ (view plot)3,163.00 (+0.61%)3,217.22 (98.31%)✅ (view plot)35.00 (-8.98%)43.57 (80.33%)✅ (view plot)139.00 (+0.13%)142.02 (97.87%)
client_sv2_mining_message_submit_standard✅ (view plot)6,242.00 (-0.52%)6,391.53 (97.66%)✅ (view plot)1,750.00 (+0.03%)1,763.57 (99.23%)✅ (view plot)2,557.00 (+0.12%)2,576.75 (99.23%)✅ (view plot)16.00 (-7.48%)22.22 (72.00%)✅ (view plot)103.00 (-0.81%)107.01 (96.26%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,825.00 (+0.33%)15,039.16 (98.58%)✅ (view plot)4,694.00 (+0.01%)4,707.57 (99.71%)✅ (view plot)6,755.00 (+0.01%)6,776.04 (99.69%)✅ (view plot)46.00 (-2.25%)51.68 (89.01%)✅ (view plot)224.00 (+0.69%)230.13 (97.34%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,522.00 (+0.17%)27,851.53 (98.82%)✅ (view plot)10,545.00 (+0.03%)10,558.82 (99.87%)✅ (view plot)15,342.00 (+0.02%)15,361.46 (99.87%)✅ (view plot)84.00 (+0.45%)89.14 (94.24%)✅ (view plot)336.00 (+0.35%)345.54 (97.24%)
client_sv2_open_channel✅ (view plot)4,527.00 (+0.76%)4,612.58 (98.14%)✅ (view plot)1,461.00 (+0.06%)1,474.84 (99.06%)✅ (view plot)2,152.00 (-0.03%)2,173.44 (99.01%)✅ (view plot)13.00 (+8.69%)15.25 (85.26%)✅ (view plot)66.00 (+1.29%)68.21 (96.76%)
client_sv2_open_channel_serialize✅ (view plot)14,262.00 (+0.30%)14,461.11 (98.62%)✅ (view plot)5,064.00 (+0.02%)5,077.84 (99.73%)✅ (view plot)7,317.00 (-0.01%)7,339.89 (99.69%)✅ (view plot)38.00 (+2.27%)41.52 (91.51%)✅ (view plot)193.00 (+0.58%)198.84 (97.06%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,700.00 (+0.27%)23,029.99 (98.57%)✅ (view plot)7,987.00 (+0.05%)8,001.38 (99.82%)✅ (view plot)11,615.00 (+0.02%)11,637.25 (99.81%)✅ (view plot)75.00 (+2.66%)81.33 (92.22%)✅ (view plot)306.00 (+0.46%)315.10 (97.11%)
client_sv2_setup_connection✅ (view plot)4,699.00 (+0.00%)4,766.42 (98.59%)✅ (view plot)1,502.00 (+0.06%)1,515.84 (99.09%)✅ (view plot)2,279.00 (+0.09%)2,300.47 (99.07%)✅ (view plot)8.00 (-10.53%)13.19 (60.66%)✅ (view plot)68.00 (+0.12%)69.64 (97.65%)
client_sv2_setup_connection_serialize✅ (view plot)16,372.00 (+0.63%)16,481.88 (99.33%)✅ (view plot)5,963.00 (+0.01%)5,976.84 (99.77%)✅ (view plot)8,652.00 (-0.04%)8,678.09 (99.70%)✅ (view plot)46.00 (+3.39%)48.69 (94.47%)✅ (view plot)214.00 (+1.32%)217.17 (98.54%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,608.00 (+0.20%)35,750.29 (99.60%)✅ (view plot)14,814.00 (+0.03%)14,828.38 (99.90%)✅ (view plot)21,748.00 (-0.01%)21,772.99 (99.89%)✅ (view plot)105.00 (+5.73%)112.32 (93.48%)✅ (view plot)381.00 (+0.35%)384.44 (99.11%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash changed the base branch from main to dev May 26, 2024 22:48
@plebhash plebhash force-pushed the standardize-cli branch 2 times, most recently from 8ac04ae to 20e6ede Compare May 26, 2024 23:24
@plebhash plebhash added good first issue Good for newcomers help wanted Extra attention is needed translation proxy SV1>SV2 translation proxy issues sv2 pool sv2 proxy refactor Implies refactoring code job-declarator-client job-declarator-server labels May 26, 2024
@rrybarczyk rrybarczyk linked an issue May 27, 2024 that may be closed by this pull request
@plebhash
Copy link
Collaborator Author

closing in favor of #937

@plebhash plebhash closed this May 27, 2024
@rrybarczyk rrybarczyk removed a link to an issue May 27, 2024
@plebhash plebhash changed the title Standardize roles CLI old May 27, 2024
@plebhash plebhash removed good first issue Good for newcomers help wanted Extra attention is needed translation proxy SV1>SV2 translation proxy issues sv2 pool sv2 proxy refactor Implies refactoring code labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant