Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE (diff dev) #888

Closed
wants to merge 22 commits into from
Closed

DO NOT MERGE (diff dev) #888

wants to merge 22 commits into from

Conversation

Fi3
Copy link
Collaborator

@Fi3 Fi3 commented May 3, 2024

No description provided.

Copy link
Contributor

github-actions bot commented May 3, 2024

🐰Bencher

ReportTue, May 7, 2024 at 15:25:46 UTC
ProjectStratum v2 (SRI)
Branch888/merge
Testbedsv1

🚨 3 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-authorize-serialize/client-sv1-authorize-serializeLatency (nanoseconds (ns))🚨 (view plot | view alert)258.37 (+4.02%)255.56 (101.10%)
client-sv1-get-authorize/client-sv1-get-authorizeLatency (nanoseconds (ns))🚨 (view plot | view alert)163.58 (+4.19%)160.73 (101.77%)
client-sv1-get-subscribe/client-sv1-get-subscribeLatency (nanoseconds (ns))🚨 (view plot | view alert)296.52 (+6.34%)292.49 (101.38%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,933.60 (-0.24%)7,294.14 (95.06%)
client-submit-serialize-deserialize✅ (view plot)7,883.40 (-0.01%)8,319.64 (94.76%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,504.70 (+0.54%)8,865.37 (95.93%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)923.12 (+2.59%)929.63 (99.30%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)704.07 (+1.04%)716.67 (98.24%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize🚨 (view plot | view alert)258.37 (+4.02%)255.56 (101.10%)
client-sv1-get-authorize/client-sv1-get-authorize🚨 (view plot | view alert)163.58 (+4.19%)160.73 (101.77%)
client-sv1-get-submit✅ (view plot)6,750.60 (+0.41%)7,093.97 (95.16%)
client-sv1-get-subscribe/client-sv1-get-subscribe🚨 (view plot | view alert)296.52 (+6.34%)292.49 (101.38%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)746.37 (-0.29%)778.79 (95.84%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)630.79 (+2.42%)640.76 (98.44%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)202.99 (-1.73%)219.26 (92.58%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 3, 2024

🐰Bencher

ReportTue, May 7, 2024 at 15:25:47 UTC
ProjectStratum v2 (SRI)
Branchdev
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_submitL2 Accesses (accesses)🚨 (view plot | view alert)75.00 (+8.54%)74.29 (100.95%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,436.00 (+0.21%)8,713.96 (96.81%)✅ (view plot)3,746.00 (+0.28%)3,854.73 (97.18%)✅ (view plot)5,251.00 (+0.26%)5,398.02 (97.28%)✅ (view plot)7.00 (-13.60%)10.52 (66.52%)✅ (view plot)90.00 (+0.30%)93.73 (96.02%)
get_submit✅ (view plot)95,549.00 (+0.01%)96,165.38 (99.36%)✅ (view plot)59,439.00 (-0.04%)59,786.08 (99.42%)✅ (view plot)85,349.00 (-0.05%)85,841.64 (99.43%)✅ (view plot)59.00 (+6.76%)62.72 (94.06%)✅ (view plot)283.00 (+0.27%)288.12 (98.22%)
get_subscribe✅ (view plot)8,007.00 (+0.47%)8,277.36 (96.73%)✅ (view plot)2,841.00 (+0.48%)2,943.58 (96.52%)✅ (view plot)3,967.00 (+0.43%)4,103.78 (96.67%)✅ (view plot)17.00 (+5.04%)19.61 (86.67%)✅ (view plot)113.00 (+0.42%)117.01 (96.58%)
serialize_authorize✅ (view plot)12,159.00 (-0.17%)12,467.49 (97.53%)✅ (view plot)5,317.00 (+0.20%)5,425.73 (98.00%)✅ (view plot)7,414.00 (+0.19%)7,561.95 (98.04%)✅ (view plot)11.00 (-0.55%)13.67 (80.47%)✅ (view plot)134.00 (-0.73%)139.21 (96.26%)
serialize_deserialize_authorize✅ (view plot)24,468.00 (+0.09%)24,679.55 (99.14%)✅ (view plot)9,898.00 (+0.06%)10,018.43 (98.80%)✅ (view plot)13,958.00 (+0.04%)14,134.34 (98.75%)✅ (view plot)37.00 (-0.06%)41.85 (88.40%)✅ (view plot)295.00 (+0.15%)297.25 (99.24%)
serialize_deserialize_handle_authorize✅ (view plot)30,203.00 (+0.23%)30,327.38 (99.59%)✅ (view plot)12,101.00 (+0.09%)12,209.73 (99.11%)✅ (view plot)17,118.00 (+0.05%)17,278.08 (99.07%)✅ (view plot)62.00 (+6.48%)63.56 (97.55%)✅ (view plot)365.00 (+0.33%)366.63 (99.55%)
serialize_deserialize_handle_submit✅ (view plot)126,472.00 (+0.06%)127,056.96 (99.54%)✅ (view plot)73,224.00 (-0.02%)73,631.10 (99.45%)✅ (view plot)104,937.00 (-0.03%)105,522.09 (99.45%)✅ (view plot)128.00 (+6.27%)132.08 (96.91%)✅ (view plot)597.00 (+0.33%)599.34 (99.61%)
serialize_deserialize_handle_subscribe✅ (view plot)27,519.00 (+0.24%)27,604.91 (99.69%)✅ (view plot)9,643.00 (+0.14%)9,745.58 (98.95%)✅ (view plot)13,634.00 (+0.10%)13,781.17 (98.93%)✅ (view plot)68.00 (+4.58%)70.54 (96.40%)✅ (view plot)387.00 (+0.26%)388.45 (99.63%)
serialize_deserialize_submit✅ (view plot)115,073.00 (+0.02%)115,633.88 (99.51%)✅ (view plot)68,001.00 (-0.05%)68,391.93 (99.43%)✅ (view plot)97,548.00 (-0.07%)98,122.76 (99.41%)🚨 (view plot | view alert)75.00 (+8.54%)74.29 (100.95%)✅ (view plot)490.00 (+0.38%)492.53 (99.49%)
serialize_deserialize_subscribe✅ (view plot)22,904.00 (+0.19%)23,101.53 (99.14%)✅ (view plot)8,195.00 (+0.15%)8,299.80 (98.74%)✅ (view plot)11,539.00 (+0.13%)11,684.82 (98.75%)✅ (view plot)40.00 (+1.71%)43.83 (91.27%)✅ (view plot)319.00 (+0.22%)321.21 (99.31%)
serialize_submit✅ (view plot)99,840.00 (-0.03%)100,474.59 (99.37%)✅ (view plot)61,483.00 (-0.04%)61,835.99 (99.43%)✅ (view plot)88,195.00 (-0.05%)88,696.75 (99.43%)✅ (view plot)61.00 (+9.37%)61.77 (98.76%)✅ (view plot)324.00 (-0.17%)329.24 (98.41%)
serialize_subscribe✅ (view plot)11,302.00 (-0.07%)11,589.59 (97.52%)✅ (view plot)4,188.00 (+0.33%)4,290.58 (97.61%)✅ (view plot)5,827.00 (+0.32%)5,963.59 (97.71%)✅ (view plot)17.00 (+4.00%)18.93 (89.83%)✅ (view plot)154.00 (-0.54%)159.13 (96.78%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 3, 2024

🐰Bencher

ReportTue, May 7, 2024 at 15:25:46 UTC
ProjectStratum v2 (SRI)
Branchdev
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,107.00 (+2.64%)2,138.03 (98.55%)✅ (view plot)473.00 (+0.52%)486.98 (97.13%)✅ (view plot)732.00 (+0.08%)755.46 (96.89%)✅ (view plot)9.00 (+21.15%)11.96 (75.24%)✅ (view plot)38.00 (+3.56%)38.75 (98.07%)
client_sv2_handle_message_mining✅ (view plot)8,219.00 (+0.21%)8,352.83 (98.40%)✅ (view plot)2,137.00 (+0.50%)2,172.17 (98.38%)✅ (view plot)3,159.00 (+0.53%)3,215.95 (98.23%)✅ (view plot)39.00 (-0.62%)43.37 (89.92%)✅ (view plot)139.00 (+0.04%)142.31 (97.68%)
client_sv2_mining_message_submit_standard✅ (view plot)6,250.00 (-0.54%)6,396.39 (97.71%)✅ (view plot)1,750.00 (+0.03%)1,763.89 (99.21%)✅ (view plot)2,555.00 (+0.07%)2,576.43 (99.17%)✅ (view plot)18.00 (+1.15%)22.95 (78.43%)✅ (view plot)103.00 (-1.00%)107.09 (96.18%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,909.00 (+0.83%)15,067.36 (98.95%)✅ (view plot)4,694.00 (+0.01%)4,707.89 (99.70%)✅ (view plot)6,749.00 (-0.07%)6,775.90 (99.60%)✅ (view plot)50.00 (+4.57%)53.10 (94.16%)✅ (view plot)226.00 (+1.48%)230.75 (97.94%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,670.00 (+0.64%)27,898.60 (99.18%)✅ (view plot)10,545.00 (+0.04%)10,559.07 (99.87%)✅ (view plot)15,335.00 (-0.02%)15,360.73 (99.83%)✅ (view plot)87.00 (+3.37%)90.61 (96.02%)✅ (view plot)340.00 (+1.41%)346.73 (98.06%)
client_sv2_open_channel✅ (view plot)4,523.00 (+0.66%)4,616.11 (97.98%)✅ (view plot)1,461.00 (+0.06%)1,475.16 (99.04%)✅ (view plot)2,153.00 (+0.02%)2,173.86 (99.04%)✅ (view plot)12.00 (0.00%)15.49 (77.46%)✅ (view plot)66.00 (+1.28%)68.28 (96.66%)
client_sv2_open_channel_serialize✅ (view plot)14,326.00 (+0.67%)14,492.89 (98.85%)✅ (view plot)5,064.00 (+0.02%)5,078.16 (99.72%)✅ (view plot)7,316.00 (-0.02%)7,340.14 (99.67%)✅ (view plot)37.00 (-0.71%)41.89 (88.32%)✅ (view plot)195.00 (+1.45%)199.70 (97.65%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,810.00 (+0.66%)23,090.00 (98.79%)✅ (view plot)7,987.00 (+0.05%)8,001.63 (99.82%)✅ (view plot)11,610.00 (-0.02%)11,637.17 (99.77%)✅ (view plot)77.00 (+5.21%)81.93 (93.98%)✅ (view plot)309.00 (+1.24%)316.69 (97.57%)
client_sv2_setup_connection✅ (view plot)4,699.00 (-0.05%)4,768.89 (98.53%)✅ (view plot)1,502.00 (+0.06%)1,516.16 (99.07%)✅ (view plot)2,279.00 (+0.11%)2,300.62 (99.06%)✅ (view plot)8.00 (-13.08%)13.49 (59.30%)✅ (view plot)68.00 (+0.06%)69.66 (97.61%)
client_sv2_setup_connection_serialize✅ (view plot)16,334.00 (+0.44%)16,467.67 (99.19%)✅ (view plot)5,963.00 (+0.01%)5,977.16 (99.76%)✅ (view plot)8,654.00 (-0.01%)8,678.68 (99.72%)✅ (view plot)45.00 (+0.87%)49.30 (91.28%)✅ (view plot)213.00 (+0.96%)216.71 (98.29%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,620.00 (+0.22%)35,773.64 (99.57%)✅ (view plot)14,814.00 (+0.03%)14,828.63 (99.90%)✅ (view plot)21,745.00 (-0.02%)21,772.99 (99.87%)✅ (view plot)108.00 (+8.00%)114.84 (94.05%)✅ (view plot)381.00 (+0.32%)384.81 (99.01%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 3, 2024

🐰Bencher

ReportTue, May 7, 2024 at 15:25:52 UTC
ProjectStratum v2 (SRI)
Branchdev
Testbedsv2

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_miningLatency (nanoseconds (ns))🚨 (view plot | view alert)84.91 (+16.00%)82.52 (102.90%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.46 (-0.19%)45.23 (98.31%)
client_sv2_handle_message_mining🚨 (view plot | view alert)84.91 (+16.00%)82.52 (102.90%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.19%)14.69 (99.58%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)263.55 (-0.47%)284.65 (92.59%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)567.41 (-4.37%)625.09 (90.77%)
client_sv2_open_channel✅ (view plot)165.38 (-0.07%)171.19 (96.60%)
client_sv2_open_channel_serialize✅ (view plot)294.93 (+3.60%)296.30 (99.54%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)376.20 (-0.05%)402.93 (93.37%)
client_sv2_setup_connection✅ (view plot)162.18 (-1.10%)175.01 (92.67%)
client_sv2_setup_connection_serialize✅ (view plot)475.64 (+0.49%)498.73 (95.37%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)949.24 (-2.04%)1,042.68 (91.04%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@xyephy
Copy link
Contributor

xyephy commented May 3, 2024

Hi @Fi3 could the deletion of : sha2 = "0.10.6" in roles/test-utils/mining-device/Cargo.toml be bringing this error:

error[E0432]: unresolved import `sha2`
  --> test-utils/mining-device/src/main.rs:10:5
   |
10 | use sha2::{Digest, Sha256};
   |     ^^^^ use of undeclared crate or module `sha2`

fi3 and others added 5 commits May 3, 2024 16:06
When the remote peer try to open an encrypted sv2 connection and then
immediatly close the tcp connection, the helper for async std and tokio
it panic, mostly of the time we don't want to panic in this situation.
This commit add an error for this case and return it.
@Fi3 Fi3 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants