Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mining_sv2 docs #1243

Merged
merged 3 commits into from
Dec 17, 2024
Merged

mining_sv2 docs #1243

merged 3 commits into from
Dec 17, 2024

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Nov 6, 2024

resolves #1205

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.30%. Comparing base (e750e1d) to head (2322230).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   19.30%   19.30%           
=======================================
  Files         164      164           
  Lines       10849    10849           
=======================================
  Hits         2094     2094           
  Misses       8755     8755
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.49% <ø> (-0.02%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.55% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🐰 Bencher Report

Branch1243/merge
Testbedsv1

⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated Cyclesestimated cyclesInstructionsinstructionsL1 AccessesaccessesL2 AccessesaccessesRAM Accessesaccesses
get_authorize📈 view plot
⚠️ NO THRESHOLD		8,451.00📈 view plot
⚠️ NO THRESHOLD		3,689.00📈 view plot
⚠️ NO THRESHOLD		5,156.00📈 view plot
⚠️ NO THRESHOLD		8.00📈 view plot
⚠️ NO THRESHOLD		93.00
get_submit📈 view plot
⚠️ NO THRESHOLD		95,453.00📈 view plot
⚠️ NO THRESHOLD		59,346.00📈 view plot
⚠️ NO THRESHOLD		85,218.00📈 view plot
⚠️ NO THRESHOLD		45.00📈 view plot
⚠️ NO THRESHOLD		286.00
get_subscribe📈 view plot
⚠️ NO THRESHOLD		7,910.00📈 view plot
⚠️ NO THRESHOLD		2,765.00📈 view plot
⚠️ NO THRESHOLD		3,845.00📈 view plot
⚠️ NO THRESHOLD		15.00📈 view plot
⚠️ NO THRESHOLD		114.00
serialize_authorize📈 view plot
⚠️ NO THRESHOLD		12,278.00📈 view plot
⚠️ NO THRESHOLD		5,266.00📈 view plot
⚠️ NO THRESHOLD		7,323.00📈 view plot
⚠️ NO THRESHOLD		11.00📈 view plot
⚠️ NO THRESHOLD		140.00
serialize_deserialize_authorize📈 view plot
⚠️ NO THRESHOLD		24,386.00📈 view plot
⚠️ NO THRESHOLD		9,838.00📈 view plot
⚠️ NO THRESHOLD		13,886.00📈 view plot
⚠️ NO THRESHOLD		35.00📈 view plot
⚠️ NO THRESHOLD		295.00
serialize_deserialize_handle_authorize📈 view plot
⚠️ NO THRESHOLD		30,118.00📈 view plot
⚠️ NO THRESHOLD		12,015.00📈 view plot
⚠️ NO THRESHOLD		16,998.00📈 view plot
⚠️ NO THRESHOLD		62.00📈 view plot
⚠️ NO THRESHOLD		366.00
serialize_deserialize_handle_submit📈 view plot
⚠️ NO THRESHOLD		126,381.00📈 view plot
⚠️ NO THRESHOLD		73,200.00📈 view plot
⚠️ NO THRESHOLD		104,911.00📈 view plot
⚠️ NO THRESHOLD		108.00📈 view plot
⚠️ NO THRESHOLD		598.00
serialize_deserialize_handle_subscribe📈 view plot
⚠️ NO THRESHOLD		27,502.00📈 view plot
⚠️ NO THRESHOLD		9,584.00📈 view plot
⚠️ NO THRESHOLD		13,542.00📈 view plot
⚠️ NO THRESHOLD		69.00📈 view plot
⚠️ NO THRESHOLD		389.00
serialize_deserialize_submit📈 view plot
⚠️ NO THRESHOLD		115,107.00📈 view plot
⚠️ NO THRESHOLD		68,060.00📈 view plot
⚠️ NO THRESHOLD		97,652.00📈 view plot
⚠️ NO THRESHOLD		68.00📈 view plot
⚠️ NO THRESHOLD		489.00
serialize_deserialize_subscribe📈 view plot
⚠️ NO THRESHOLD		22,904.00📈 view plot
⚠️ NO THRESHOLD		8,143.00📈 view plot
⚠️ NO THRESHOLD		11,459.00📈 view plot
⚠️ NO THRESHOLD		42.00📈 view plot
⚠️ NO THRESHOLD		321.00
serialize_submit📈 view plot
⚠️ NO THRESHOLD		99,842.00📈 view plot
⚠️ NO THRESHOLD		61,408.00📈 view plot
⚠️ NO THRESHOLD		88,077.00📈 view plot
⚠️ NO THRESHOLD		50.00📈 view plot
⚠️ NO THRESHOLD		329.00
serialize_subscribe📈 view plot
⚠️ NO THRESHOLD		11,355.00📈 view plot
⚠️ NO THRESHOLD		4,118.00📈 view plot
⚠️ NO THRESHOLD		5,705.00📈 view plot
⚠️ NO THRESHOLD		17.00📈 view plot
⚠️ NO THRESHOLD		159.00
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🐰 Bencher Report

Branch1243/merge
Testbedsv2

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
client_sv2_handle_message_common📈 view plot
⚠️ NO THRESHOLD		44.24
client_sv2_handle_message_mining📈 view plot
⚠️ NO THRESHOLD		74.87
client_sv2_mining_message_submit_standard📈 view plot
⚠️ NO THRESHOLD		14.64
client_sv2_mining_message_submit_standard_serialize📈 view plot
⚠️ NO THRESHOLD		268.07
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD		592.77
client_sv2_open_channel📈 view plot
⚠️ NO THRESHOLD		146.63
client_sv2_open_channel_serialize📈 view plot
⚠️ NO THRESHOLD		279.63
client_sv2_open_channel_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD		372.80
client_sv2_setup_connection📈 view plot
⚠️ NO THRESHOLD		164.11
client_sv2_setup_connection_serialize📈 view plot
⚠️ NO THRESHOLD		487.29
client_sv2_setup_connection_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD		986.78
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🐰 Bencher Report

Branch1243/merge
Testbedsv1

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
client-submit-serialize📈 view plot
⚠️ NO THRESHOLD		6,710.70
client-submit-serialize-deserialize📈 view plot
⚠️ NO THRESHOLD		7,583.60
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
⚠️ NO THRESHOLD		8,205.20
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
⚠️ NO THRESHOLD		906.46
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
⚠️ NO THRESHOLD		699.95
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
⚠️ NO THRESHOLD		246.25
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
⚠️ NO THRESHOLD		157.88
client-sv1-get-submit📈 view plot
⚠️ NO THRESHOLD		6,487.70
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
⚠️ NO THRESHOLD		278.24
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
⚠️ NO THRESHOLD		736.61
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
⚠️ NO THRESHOLD		590.96
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
⚠️ NO THRESHOLD		203.98
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🐰 Bencher Report

Branch1243/merge
Testbedsv2

⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated Cyclesestimated cyclesInstructionsinstructionsL1 AccessesaccessesL2 AccessesaccessesRAM Accessesaccesses
client_sv2_handle_message_common📈 view plot
⚠️ NO THRESHOLD		2,103.00📈 view plot
⚠️ NO THRESHOLD		473.00📈 view plot
⚠️ NO THRESHOLD		733.00📈 view plot
⚠️ NO THRESHOLD		8.00📈 view plot
⚠️ NO THRESHOLD		38.00
client_sv2_handle_message_mining📈 view plot
⚠️ NO THRESHOLD		8,192.00📈 view plot
⚠️ NO THRESHOLD		2,137.00📈 view plot
⚠️ NO THRESHOLD		3,162.00📈 view plot
⚠️ NO THRESHOLD		33.00📈 view plot
⚠️ NO THRESHOLD		139.00
client_sv2_mining_message_submit_standard📈 view plot
⚠️ NO THRESHOLD		6,289.00📈 view plot
⚠️ NO THRESHOLD		1,750.00📈 view plot
⚠️ NO THRESHOLD		2,549.00📈 view plot
⚠️ NO THRESHOLD		20.00📈 view plot
⚠️ NO THRESHOLD		104.00
client_sv2_mining_message_submit_standard_serialize📈 view plot
⚠️ NO THRESHOLD		14,644.00📈 view plot
⚠️ NO THRESHOLD		4,694.00📈 view plot
⚠️ NO THRESHOLD		6,759.00📈 view plot
⚠️ NO THRESHOLD		44.00📈 view plot
⚠️ NO THRESHOLD		219.00
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD		27,438.00📈 view plot
⚠️ NO THRESHOLD		10,585.00📈 view plot
⚠️ NO THRESHOLD		15,403.00📈 view plot
⚠️ NO THRESHOLD		83.00📈 view plot
⚠️ NO THRESHOLD		332.00
client_sv2_open_channel📈 view plot
⚠️ NO THRESHOLD		4,379.00📈 view plot
⚠️ NO THRESHOLD		1,461.00📈 view plot
⚠️ NO THRESHOLD		2,159.00📈 view plot
⚠️ NO THRESHOLD		10.00📈 view plot
⚠️ NO THRESHOLD		62.00
client_sv2_open_channel_serialize📈 view plot
⚠️ NO THRESHOLD		13,966.00📈 view plot
⚠️ NO THRESHOLD		5,064.00📈 view plot
⚠️ NO THRESHOLD		7,331.00📈 view plot
⚠️ NO THRESHOLD		32.00📈 view plot
⚠️ NO THRESHOLD		185.00
client_sv2_open_channel_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD		22,613.00📈 view plot
⚠️ NO THRESHOLD		8,027.00📈 view plot
⚠️ NO THRESHOLD		11,673.00📈 view plot
⚠️ NO THRESHOLD		81.00📈 view plot
⚠️ NO THRESHOLD		301.00
client_sv2_setup_connection📈 view plot
⚠️ NO THRESHOLD		4,677.00📈 view plot
⚠️ NO THRESHOLD		1,502.00📈 view plot
⚠️ NO THRESHOLD		2,277.00📈 view plot
⚠️ NO THRESHOLD		11.00📈 view plot
⚠️ NO THRESHOLD		67.00
client_sv2_setup_connection_serialize📈 view plot
⚠️ NO THRESHOLD		16,102.00📈 view plot
⚠️ NO THRESHOLD		5,963.00📈 view plot
⚠️ NO THRESHOLD		8,667.00📈 view plot
⚠️ NO THRESHOLD		38.00📈 view plot
⚠️ NO THRESHOLD		207.00
client_sv2_setup_connection_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD		35,450.00📈 view plot
⚠️ NO THRESHOLD		14,855.00📈 view plot
⚠️ NO THRESHOLD		21,825.00📈 view plot
⚠️ NO THRESHOLD		93.00📈 view plot
⚠️ NO THRESHOLD		376.00
🐰 View full continuous benchmarking report in Bencher

@GitGab19 GitGab19 mentioned this pull request Nov 12, 2024
Open
78 tasks
@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch from 72e9bb2 to 3bf8747 Compare December 2, 2024 10:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-05-mining-msgs-docs
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,586.80
(-0.63%)		7,065.17
(93.23%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,409.70
(-1.06%)		8,054.11
(92.00%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,907.10
(-2.31%)		8,560.29
(92.37%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		873.38
(+0.98%)		924.55
(94.47%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		672.65
(+0.22%)		703.28
(95.64%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		248.95
(+0.32%)		268.30
(92.79%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		157.88
(+0.57%)		163.88
(96.34%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,292.00
(-1.95%)		7,013.46
(89.71%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		279.94
(-0.08%)		304.42
(91.96%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		754.52
(+3.58%)		785.98
(96.00%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		606.49
(+2.75%)		634.38
(95.60%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		207.93
(+1.03%)		216.69
(95.96%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-05-mining-msgs-docs
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.85
(+0.63%)		46.69
(96.06%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		72.95
(-5.06%)		99.88
(73.04%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(+0.07%)		14.76
(99.41%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		273.24
(+2.49%)		298.86
(91.43%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		628.06
(+2.01%)		668.66
(93.93%)
client_sv2_open_channel📈 view plot
🚷 view threshold		164.61
(+1.02%)		186.40
(88.31%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		284.80
(+0.04%)		309.23
(92.10%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		380.06
(-0.97%)		412.10
(92.22%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		157.48
(-1.75%)		171.45
(91.85%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		445.22
(-5.44%)		557.04
(79.93%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		991.27
(-0.57%)		1,073.32
(92.36%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-05-mining-msgs-docs
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,482.00
(+0.25%)		8,682.01
(97.70%)		📈 view plot
🚷 view threshold		3,663.00
(-2.03%)		3,862.37
(94.84%)		📈 view plot
🚷 view threshold		5,107.00
(-2.51%)		5,447.84
(93.74%)		📈 view plot
🚷 view threshold		10.00
(+30.35%)		14.94
(66.95%)		📈 view plot
🚷 view threshold		95.00
(+4.41%)		95.83
(99.13%)
get_submit📈 view plot
🚷 view threshold		95,358.00
(-0.04%)		95,786.55
(99.55%)		📈 view plot
🚷 view threshold		59,263.00
(-0.29%)		59,714.16
(99.24%)		📈 view plot
🚷 view threshold		85,073.00
(-0.34%)		85,826.29
(99.12%)		📈 view plot
🚷 view threshold		48.00
(+8.80%)		58.82
(81.60%)		📈 view plot
🚷 view threshold		287.00
(+2.33%)		290.28
(98.87%)
get_subscribe📈 view plot
🚷 view threshold		7,953.00
(-0.75%)		8,233.22
(96.60%)		📈 view plot
🚷 view threshold		2,758.00
(-2.39%)		2,940.58
(93.79%)		📈 view plot
🚷 view threshold		3,833.00
(-2.85%)		4,138.86
(92.61%)		📈 view plot
🚷 view threshold		12.00
(+2.26%)		19.23
(62.39%)		📈 view plot
🚷 view threshold		116.00
(+1.27%)		117.80
(98.48%)
serialize_authorize📈 view plot
🚷 view threshold		12,271.00
(-0.04%)		12,515.93
(98.04%)		📈 view plot
🚷 view threshold		5,240.00
(-1.35%)		5,427.31
(96.55%)		📈 view plot
🚷 view threshold		7,276.00
(-1.70%)		7,603.23
(95.70%)		📈 view plot
🚷 view threshold		12.00
(+26.21%)		17.88
(67.13%)		📈 view plot
🚷 view threshold		141.00
(+2.25%)		142.18
(99.17%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,636.00
(-0.30%)		25,181.47
(97.83%)		📈 view plot
🚷 view threshold		9,786.00
(-0.91%)		10,033.00
(97.54%)		📈 view plot
🚷 view threshold		13,786.00
(-1.10%)		14,199.72
(97.09%)		📈 view plot
🚷 view threshold		35.00
(+0.04%)		45.07
(77.65%)		📈 view plot
🚷 view threshold		305.00
(+0.75%)		313.59
(97.26%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,253.00
(-0.26%)		30,706.34
(98.52%)		📈 view plot
🚷 view threshold		11,989.00
(-0.65%)		12,202.00
(98.25%)		📈 view plot
🚷 view threshold		16,953.00
(-0.78%)		17,309.30
(97.94%)		📈 view plot
🚷 view threshold		56.00
(+0.99%)		66.81
(83.82%)		📈 view plot
🚷 view threshold		372.00
(+0.40%)		379.68
(97.98%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,452.00
(-0.02%)		126,786.37
(99.74%)		📈 view plot
🚷 view threshold		73,117.00
(-0.21%)		73,520.20
(99.45%)		📈 view plot
🚷 view threshold		104,762.00
(-0.26%)		105,479.92
(99.32%)		📈 view plot
🚷 view threshold		110.00
(+4.16%)		123.57
(89.02%)		📈 view plot
🚷 view threshold		604.00
(+1.11%)		607.16
(99.48%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,863.00
(-0.10%)		28,466.15
(97.88%)		📈 view plot
🚷 view threshold		9,577.00
(-0.67%)		9,753.03
(98.20%)		📈 view plot
🚷 view threshold		13,518.00
(-0.85%)		13,825.32
(97.78%)		📈 view plot
🚷 view threshold		69.00
(+8.51%)		76.03
(90.76%)		📈 view plot
🚷 view threshold		400.00
(+0.45%)		412.73
(96.91%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,181.00
(-0.06%)		115,735.42
(99.52%)		📈 view plot
🚷 view threshold		67,894.00
(-0.28%)		68,418.38
(99.23%)		📈 view plot
🚷 view threshold		97,356.00
(-0.35%)		98,280.75
(99.06%)		📈 view plot
🚷 view threshold		72.00
(+13.74%)		82.40
(87.37%)		📈 view plot
🚷 view threshold		499.00
(+1.31%)		500.40
(99.72%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,236.00
(-0.30%)		23,866.21
(97.36%)		📈 view plot
🚷 view threshold		8,129.00
(-0.83%)		8,309.88
(97.82%)		📈 view plot
🚷 view threshold		11,426.00
(-1.01%)		11,733.63
(97.38%)		📈 view plot
🚷 view threshold		38.00
(+0.64%)		47.87
(79.39%)		📈 view plot
🚷 view threshold		332.00
(+0.39%)		344.25
(96.44%)
serialize_submit📈 view plot
🚷 view threshold		99,823.00
(-0.00%)		100,221.84
(99.60%)		📈 view plot
🚷 view threshold		61,325.00
(-0.26%)		61,741.31
(99.33%)		📈 view plot
🚷 view threshold		87,928.00
(-0.32%)		88,655.39
(99.18%)		📈 view plot
🚷 view threshold		55.00
(+17.92%)		63.60
(86.48%)		📈 view plot
🚷 view threshold		332.00
(+2.08%)		335.53
(98.95%)
serialize_subscribe📈 view plot
🚷 view threshold		11,436.00
(+0.23%)		11,620.05
(98.42%)		📈 view plot
🚷 view threshold		4,111.00
(-1.51%)		4,281.08
(96.03%)		📈 view plot
🚷 view threshold		5,691.00
(-1.93%)		5,991.31
(94.99%)		📈 view plot
🚷 view threshold		15.00
(+15.66%)		21.47
(69.88%)		📈 view plot
🚷 view threshold		162.00
(+2.31%)		163.51
(99.08%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-05-mining-msgs-docs
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,205.00
(+4.73%)		2,221.97
(99.24%)		📈 view plot
🚷 view threshold		473.00
(-0.06%)		489.01
(96.73%)		📈 view plot
🚷 view threshold		730.00
(-0.76%)		758.02
(96.30%)		📈 view plot
🚷 view threshold		8.00
(+54.22%)		13.24
(60.42%)		📈 view plot
🚷 view threshold		41.00
(+6.78%)		41.51
(98.76%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,284.00
(+0.83%)		8,364.35
(99.04%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,154.00
(-0.19%)		3,171.23
(99.46%)		📈 view plot
🚷 view threshold		39.00
(+10.05%)		41.51
(93.96%)		📈 view plot
🚷 view threshold		141.00
(+1.15%)		143.49
(98.26%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,365.00
(+1.11%)		6,437.28
(98.88%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,767.36
(99.02%)		📈 view plot
🚷 view threshold		2,545.00
(-0.30%)		2,576.22
(98.79%)		📈 view plot
🚷 view threshold		22.00
(+28.88%)		24.49
(89.82%)		📈 view plot
🚷 view threshold		106.00
(+1.44%)		108.44
(97.75%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,824.00
(+0.67%)		14,945.52
(99.19%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.36
(99.63%)		📈 view plot
🚷 view threshold		6,744.00
(-0.20%)		6,785.85
(99.38%)		📈 view plot
🚷 view threshold		55.00
(+24.16%)		58.26
(94.40%)		📈 view plot
🚷 view threshold		223.00
(+0.75%)		226.88
(98.29%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,792.00
(+0.82%)		27,950.93
(99.43%)		📈 view plot
🚷 view threshold		10,645.00
(+0.45%)		10,675.46
(99.71%)		📈 view plot
🚷 view threshold		15,502.00
(+0.51%)		15,555.53
(99.66%)		📈 view plot
🚷 view threshold		92.00
(+11.84%)		94.37
(97.49%)		📈 view plot
🚷 view threshold		338.00
(+0.83%)		342.17
(98.78%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,523.00
(+3.11%)		4,551.64
(99.37%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,477.01
(98.92%)		📈 view plot
🚷 view threshold		2,153.00
(-0.35%)		2,183.79
(98.59%)		📈 view plot
🚷 view threshold		12.00
(+44.09%)		14.88
(80.63%)		📈 view plot
🚷 view threshold		66.00
(+5.75%)		67.09
(98.38%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,116.00
(+0.68%)		14,222.40
(99.25%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,080.01
(99.68%)		📈 view plot
🚷 view threshold		7,316.00
(-0.14%)		7,351.34
(99.52%)		📈 view plot
🚷 view threshold		44.00
(+23.97%)		45.48
(96.75%)		📈 view plot
🚷 view threshold		188.00
(+0.97%)		192.03
(97.90%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,888.00
(+0.94%)		22,964.26
(99.67%)		📈 view plot
🚷 view threshold		8,040.00
(+0.13%)		8,056.61
(99.79%)		📈 view plot
🚷 view threshold		11,688.00
(+0.06%)		11,719.13
(99.73%)		📈 view plot
🚷 view threshold		84.00
(+12.27%)		86.30
(97.33%)		📈 view plot
🚷 view threshold		308.00
(+1.51%)		310.67
(99.14%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,749.00
(+1.34%)		4,786.31
(99.22%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,518.01
(98.95%)		📈 view plot
🚷 view threshold		2,274.00
(-0.18%)		2,299.51
(98.89%)		📈 view plot
🚷 view threshold		12.00
(+23.87%)		16.52
(72.65%)		📈 view plot
🚷 view threshold		69.00
(+2.34%)		70.09
(98.45%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,264.00
(+0.71%)		16,329.19
(99.60%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,979.01
(99.73%)		📈 view plot
🚷 view threshold		8,649.00
(-0.17%)		8,691.64
(99.51%)		📈 view plot
🚷 view threshold		53.00
(+32.55%)		54.08
(98.00%)		📈 view plot
🚷 view threshold		210.00
(+0.89%)		212.66
(98.75%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,786.00
(+0.60%)		35,857.66
(99.80%)		📈 view plot
🚷 view threshold		14,888.00
(+0.18%)		14,908.35
(99.86%)		📈 view plot
🚷 view threshold		21,866.00
(+0.14%)		21,909.45
(99.80%)		📈 view plot
🚷 view threshold		110.00
(+19.13%)		112.37
(97.89%)		📈 view plot
🚷 view threshold		382.00
(+0.72%)		384.92
(99.24%)
🐰 View full continuous benchmarking report in Bencher

@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch 3 times, most recently from a53cc3c to 61e1918 Compare December 8, 2024 14:43
@jbesraa jbesraa marked this pull request as ready for review December 8, 2024 14:47
@plebhash plebhash self-requested a review December 8, 2024 14:52
GitGab19
GitGab19 reviewed Dec 9, 2024
View reviewed changes
protocols/v2/subprotocols/mining/README.md Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/close_channel.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/close_channel.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/lib.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/lib.rs Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/submit_shares.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/submit_shares.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/submit_shares.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/update_channel.rs Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/src/update_channel.rs Outdated Show resolved Hide resolved
@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch from d9522e2 to 904a9c9 Compare December 12, 2024 07:07
@plebhash plebhash mentioned this pull request Dec 13, 2024
Closed
@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch 2 times, most recently from 1ed1eaa to ff8cedb Compare December 13, 2024 12:25
@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch from ff8cedb to 8a63dbc Compare December 16, 2024 10:19
@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch from 8a63dbc to b0d182a Compare December 16, 2024 10:28
@jbesraa jbesraa force-pushed the 2024-11-05-mining-msgs-docs branch from b0d182a to 47bd09a Compare December 17, 2024 09:54
@plebhash plebhash added the ready-to-be-merged triggers auto rebase bot label Dec 17, 2024
@pavlenex pavlenex force-pushed the 2024-11-05-mining-msgs-docs branch from 47bd09a to 2322230 Compare December 17, 2024 10:31
@plebhash plebhash merged commit e07e045 into stratum-mining:main Dec 17, 2024
37 checks passed
@plebhash plebhash mentioned this pull request Dec 17, 2024
Closed
4 tasks
@jbesraa jbesraa deleted the 2024-11-05-mining-msgs-docs branch February 12, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

@plebhash plebhash plebhash approved these changes

Assignees
No one assigned
Labels
ready-to-be-merged triggers auto rebase bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need Rust docs on protocols::v2::subprotocols::mining
3 participants
@jbesraa @GitGab19 @plebhash