Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update roles/Cargo.lock #1150

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 28, 2024

unblock #1039 + #1102

Copy link
Contributor

🐰Bencher

ReportWed, August 28, 2024 at 16:44:10 UTC
ProjectStratum v2 (SRI)
Branchupdate-lockfile
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)45.32 (+1.60%)45.44 (99.74%)
client_sv2_handle_message_mining✅ (view plot)72.50 (-0.89%)80.63 (89.91%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.12%)14.69 (99.59%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)270.77 (+1.97%)285.36 (94.89%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)577.04 (-2.72%)625.43 (92.26%)
client_sv2_open_channel✅ (view plot)161.38 (-2.51%)171.09 (94.32%)
client_sv2_open_channel_serialize✅ (view plot)283.29 (+0.11%)293.58 (96.50%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)371.83 (-1.48%)419.72 (88.59%)
client_sv2_setup_connection✅ (view plot)163.24 (-0.22%)174.34 (93.64%)
client_sv2_setup_connection_serialize✅ (view plot)457.38 (-3.33%)502.74 (90.98%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)941.50 (-3.06%)1,039.65 (90.56%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportWed, August 28, 2024 at 16:44:14 UTC
ProjectStratum v2 (SRI)
Branch1150/merge
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-get-authorize/client-sv1-get-authorizeLatency (nanoseconds (ns))🚨 (view plot | view alert)163.32 (+3.87%)162.41 (100.56%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,463.90 (-5.87%)7,372.36 (87.68%)
client-submit-serialize-deserialize✅ (view plot)7,382.40 (-5.24%)8,353.37 (88.38%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,077.50 (-3.44%)8,854.87 (91.22%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)889.45 (-1.18%)928.01 (95.85%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)697.38 (-0.27%)721.43 (96.67%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)254.77 (+2.41%)256.32 (99.40%)
client-sv1-get-authorize/client-sv1-get-authorize🚨 (view plot | view alert)163.32 (+3.87%)162.41 (100.56%)
client-sv1-get-submit✅ (view plot)6,306.10 (-5.12%)7,136.68 (88.36%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)279.62 (+0.37%)290.03 (96.41%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)750.51 (+0.09%)779.65 (96.26%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)607.57 (-1.06%)636.87 (95.40%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)204.06 (-1.33%)219.07 (93.15%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportWed, August 28, 2024 at 16:44:15 UTC
ProjectStratum v2 (SRI)
Branchupdate-lockfile
Testbedsv2

🚨 8 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonEstimated Cycles (estimated cycles)🚨 (view plot | view alert)2,153.00 (+4.66%)2,141.29 (100.55%)
client_sv2_handle_message_commonL2 Accesses (accesses)🚨 (view plot | view alert)12.00 (+63.99%)11.72 (102.38%)
client_sv2_handle_message_commonRAM Accesses (accesses)🚨 (view plot | view alert)39.00 (+5.95%)38.85 (100.38%)
client_sv2_mining_message_submit_standardL2 Accesses (accesses)🚨 (view plot | view alert)23.00 (+31.13%)22.52 (102.11%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.40%)10,588.73 (100.02%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.47%)8,026.17 (100.01%)
client_sv2_open_channel_serialize_deserializeL2 Accesses (accesses)🚨 (view plot | view alert)85.00 (+14.94%)83.05 (102.35%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.26%)14,853.97 (100.01%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)2,153.00 (+4.66%)2,141.29 (100.55%)✅ (view plot)473.00 (+0.40%)485.80 (97.37%)✅ (view plot)728.00 (-0.58%)753.63 (96.60%)🚨 (view plot | view alert)12.00 (+63.99%)11.72 (102.38%)🚨 (view plot | view alert)39.00 (+5.95%)38.85 (100.38%)
client_sv2_handle_message_mining✅ (view plot)8,251.00 (+0.58%)8,337.26 (98.97%)✅ (view plot)2,143.00 (+0.63%)2,171.80 (98.67%)✅ (view plot)3,166.00 (+0.57%)3,216.08 (98.44%)✅ (view plot)37.00 (-2.71%)43.32 (85.42%)✅ (view plot)140.00 (+0.71%)142.02 (98.58%)
client_sv2_mining_message_submit_standard✅ (view plot)6,378.00 (+1.55%)6,392.47 (99.77%)✅ (view plot)1,756.00 (+0.31%)1,764.23 (99.53%)✅ (view plot)2,553.00 (-0.07%)2,575.67 (99.12%)🚨 (view plot | view alert)23.00 (+31.13%)22.52 (102.11%)✅ (view plot)106.00 (+1.97%)106.93 (99.13%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,877.00 (+0.62%)15,025.42 (99.01%)✅ (view plot)4,700.00 (+0.12%)4,708.23 (99.83%)✅ (view plot)6,757.00 (+0.02%)6,775.70 (99.72%)✅ (view plot)49.00 (+4.29%)51.46 (95.22%)✅ (view plot)225.00 (+1.03%)229.69 (97.96%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,659.00 (+0.59%)27,845.47 (99.33%)🚨 (view plot | view alert)10,591.00 (+0.40%)10,588.73 (100.02%)✅ (view plot)15,404.00 (+0.36%)15,405.32 (99.99%)✅ (view plot)85.00 (+2.14%)88.76 (95.76%)✅ (view plot)338.00 (+0.85%)344.92 (97.99%)
client_sv2_open_channel✅ (view plot)4,395.00 (-1.78%)4,629.09 (94.94%)✅ (view plot)1,461.00 (+0.04%)1,473.64 (99.14%)✅ (view plot)2,155.00 (+0.07%)2,172.54 (99.19%)✅ (view plot)14.00 (+15.75%)15.17 (92.28%)✅ (view plot)62.00 (-4.01%)68.91 (89.97%)
client_sv2_open_channel_serialize✅ (view plot)14,114.00 (-0.61%)14,449.35 (97.68%)✅ (view plot)5,064.00 (+0.01%)5,076.64 (99.75%)✅ (view plot)7,324.00 (+0.07%)7,339.90 (99.78%)✅ (view plot)35.00 (-4.71%)41.30 (84.75%)✅ (view plot)189.00 (-1.24%)198.48 (95.23%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,731.00 (+0.37%)23,001.81 (98.82%)🚨 (view plot | view alert)8,027.00 (+0.47%)8,026.17 (100.01%)✅ (view plot)11,666.00 (+0.38%)11,671.93 (99.95%)🚨 (view plot | view alert)85.00 (+14.94%)83.05 (102.35%)✅ (view plot)304.00 (-0.14%)314.13 (96.78%)
client_sv2_setup_connection✅ (view plot)4,723.00 (+0.56%)4,762.14 (99.18%)✅ (view plot)1,502.00 (+0.04%)1,514.64 (99.17%)✅ (view plot)2,273.00 (-0.16%)2,297.91 (98.92%)✅ (view plot)14.00 (+46.27%)14.65 (95.55%)✅ (view plot)68.00 (+0.33%)69.63 (97.66%)
client_sv2_setup_connection_serialize✅ (view plot)16,214.00 (-0.28%)16,473.89 (98.42%)✅ (view plot)5,963.00 (+0.01%)5,975.64 (99.79%)✅ (view plot)8,654.00 (-0.02%)8,676.25 (99.74%)✅ (view plot)49.00 (+9.08%)49.27 (99.46%)✅ (view plot)209.00 (-0.87%)217.00 (96.31%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,622.00 (+0.23%)35,738.43 (99.67%)🚨 (view plot | view alert)14,855.00 (+0.26%)14,853.97 (100.01%)✅ (view plot)21,812.00 (+0.24%)21,816.22 (99.98%)✅ (view plot)102.00 (+3.06%)111.66 (91.35%)✅ (view plot)380.00 (+0.11%)384.10 (98.93%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportWed, August 28, 2024 at 16:44:16 UTC
ProjectStratum v2 (SRI)
Branchupdate-lockfile
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,477.00 (+0.48%)8,738.04 (97.01%)✅ (view plot)3,772.00 (+0.78%)3,862.93 (97.65%)✅ (view plot)5,297.00 (+0.90%)5,413.77 (97.84%)✅ (view plot)6.00 (-20.25%)10.60 (56.59%)✅ (view plot)90.00 (+0.02%)94.10 (95.64%)
get_submit✅ (view plot)95,654.00 (+0.10%)96,154.06 (99.48%)✅ (view plot)59,522.00 (+0.08%)59,770.24 (99.58%)✅ (view plot)85,499.00 (+0.09%)85,829.48 (99.61%)✅ (view plot)50.00 (-7.57%)62.96 (79.41%)✅ (view plot)283.00 (+0.32%)288.71 (98.02%)
get_subscribe✅ (view plot)8,038.00 (+0.71%)8,292.65 (96.93%)✅ (view plot)2,848.00 (+0.66%)2,945.25 (96.70%)✅ (view plot)3,983.00 (+0.73%)4,108.20 (96.95%)✅ (view plot)13.00 (-15.33%)21.01 (61.88%)✅ (view plot)114.00 (+1.01%)117.58 (96.95%)
serialize_authorize✅ (view plot)12,328.00 (+0.88%)12,547.66 (98.25%)✅ (view plot)5,343.00 (+0.55%)5,433.93 (98.33%)✅ (view plot)7,458.00 (+0.62%)7,576.36 (98.44%)✅ (view plot)8.00 (-22.16%)13.85 (57.75%)✅ (view plot)138.00 (+1.53%)141.28 (97.68%)
serialize_deserialize_authorize✅ (view plot)24,606.00 (+0.48%)24,753.78 (99.40%)✅ (view plot)9,950.00 (+0.45%)10,037.46 (99.13%)✅ (view plot)14,051.00 (+0.52%)14,170.29 (99.16%)✅ (view plot)32.00 (-10.73%)42.25 (75.74%)✅ (view plot)297.00 (+0.63%)298.65 (99.45%)
serialize_deserialize_handle_authorize✅ (view plot)30,202.00 (+0.18%)30,383.12 (99.40%)✅ (view plot)12,127.00 (+0.24%)12,217.93 (99.26%)✅ (view plot)17,167.00 (+0.26%)17,291.15 (99.28%)✅ (view plot)59.00 (+1.29%)64.52 (91.44%)✅ (view plot)364.00 (+0.04%)367.48 (99.05%)
serialize_deserialize_handle_submit✅ (view plot)126,571.00 (+0.12%)127,073.10 (99.60%)✅ (view plot)73,307.00 (+0.07%)73,612.65 (99.58%)✅ (view plot)105,096.00 (+0.09%)105,507.46 (99.61%)✅ (view plot)109.00 (-7.84%)132.81 (82.07%)✅ (view plot)598.00 (+0.48%)601.41 (99.43%)
serialize_deserialize_handle_subscribe✅ (view plot)27,512.00 (+0.18%)27,662.54 (99.46%)✅ (view plot)9,650.00 (+0.19%)9,747.25 (99.00%)✅ (view plot)13,652.00 (+0.21%)13,782.69 (99.05%)✅ (view plot)63.00 (-3.56%)73.45 (85.78%)✅ (view plot)387.00 (+0.25%)389.69 (99.31%)
serialize_deserialize_submit✅ (view plot)115,367.00 (+0.21%)115,714.41 (99.70%)✅ (view plot)68,167.00 (+0.14%)68,407.45 (99.65%)✅ (view plot)97,842.00 (+0.16%)98,168.89 (99.67%)✅ (view plot)61.00 (-10.60%)77.00 (79.22%)✅ (view plot)492.00 (+0.72%)494.38 (99.52%)
serialize_deserialize_subscribe✅ (view plot)23,024.00 (+0.57%)23,169.61 (99.37%)✅ (view plot)8,209.00 (+0.28%)8,303.72 (98.86%)✅ (view plot)11,564.00 (+0.29%)11,691.61 (98.91%)✅ (view plot)38.00 (-2.45%)44.15 (86.08%)✅ (view plot)322.00 (+0.91%)323.45 (99.55%)
serialize_submit✅ (view plot)100,061.00 (+0.15%)100,503.36 (99.56%)✅ (view plot)61,566.00 (+0.07%)61,818.96 (99.59%)✅ (view plot)88,346.00 (+0.09%)88,682.50 (99.62%)✅ (view plot)47.00 (-13.38%)64.53 (72.84%)✅ (view plot)328.00 (+0.89%)331.55 (98.93%)
serialize_subscribe✅ (view plot)11,477.00 (+1.16%)11,664.98 (98.39%)✅ (view plot)4,195.00 (+0.45%)4,292.25 (97.73%)✅ (view plot)5,837.00 (+0.43%)5,966.29 (97.83%)✅ (view plot)15.00 (-4.97%)19.87 (75.49%)✅ (view plot)159.00 (+2.01%)161.58 (98.40%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Collaborator

@rrybarczyk rrybarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! So great to have these Cargo.lock files properly handled.

Locally, I merged #1039 branch into this one and ran the ./.githooks/pre-push script and it completed successfully now:

Screenshot 2024-08-28 at 12 49 30 PM Screenshot 2024-08-28 at 12 50 18 PM

@plebhash plebhash merged commit 61616b9 into stratum-mining:main Aug 28, 2024
33 checks passed
@plebhash plebhash deleted the update-lockfile branch August 28, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants