Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split MG CI jobs #1056

Merged
merged 1 commit into from
Jul 17, 2024
Merged

split MG CI jobs #1056

merged 1 commit into from
Jul 17, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Jul 16, 2024

this is a paliative solution to the issues described on #1028

first, we split the Coverage CI into two files:

  • coverage.yaml: which remains with the tarpaulin tests, fully focused on code coverage
  • mg.yaml: which now focuses on Message Generator tests only

we make MG CI slightly less worse by breaking tests into multiple jobs and allowing us to re-run false alarms in a more agile way

before:
image

after:
image

specific MG tests are still subject to false alarms... and when they happen, our only recourse is clicking this button:
image

but now, instead of re-running the entire MG test stack, we only re-run specific MG tests that failed, which is now possible because they are separate jobs:

image

Copy link
Contributor

github-actions bot commented Jul 16, 2024

🐰Bencher

ReportTue, July 16, 2024 at 14:56:08 UTC
ProjectStratum v2 (SRI)
Branchsplit-mg-ci-jobs
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.73 (+0.36%)45.22 (98.93%)
client_sv2_handle_message_mining✅ (view plot)72.77 (-0.18%)79.89 (91.09%)
client_sv2_mining_message_submit_standard✅ (view plot)14.65 (-0.01%)14.69 (99.72%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)263.83 (-0.21%)284.68 (92.67%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)583.51 (-2.08%)643.21 (90.72%)
client_sv2_open_channel✅ (view plot)170.15 (+1.85%)181.25 (93.88%)
client_sv2_open_channel_serialize✅ (view plot)289.03 (+2.46%)294.18 (98.25%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)391.91 (+3.39%)421.72 (92.93%)
client_sv2_setup_connection✅ (view plot)164.59 (+0.44%)174.15 (94.51%)
client_sv2_setup_connection_serialize✅ (view plot)454.37 (-3.56%)506.42 (89.72%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)960.18 (-1.17%)1,038.22 (92.48%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jul 16, 2024

🐰Bencher

ReportTue, July 16, 2024 at 15:41:16 UTC
ProjectStratum v2 (SRI)
Branch1056/merge
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handleLatency (nanoseconds (ns))🚨 (view plot | view alert)797.12 (+5.90%)789.82 (100.92%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,569.50 (-4.01%)7,356.97 (89.30%)
client-submit-serialize-deserialize✅ (view plot)7,406.70 (-4.58%)8,315.37 (89.07%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,039.30 (-3.54%)8,834.01 (91.00%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)893.66 (-0.68%)927.45 (96.36%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)700.36 (+0.15%)721.70 (97.04%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)248.97 (+0.40%)254.61 (97.78%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.42 (+0.10%)161.98 (97.18%)
client-sv1-get-submit✅ (view plot)6,324.50 (-4.29%)7,135.45 (88.63%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)282.71 (+1.32%)290.66 (97.26%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle🚨 (view plot | view alert)797.12 (+5.90%)789.82 (100.92%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)619.56 (+0.73%)637.51 (97.18%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)204.28 (-0.84%)218.16 (93.64%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jul 16, 2024

🐰Bencher

ReportTue, July 16, 2024 at 15:41:18 UTC
ProjectStratum v2 (SRI)
Branchsplit-mg-ci-jobs
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,077.00 (+1.13%)2,127.88 (97.61%)✅ (view plot)473.00 (+0.42%)485.60 (97.40%)✅ (view plot)732.00 (-0.02%)753.42 (97.16%)✅ (view plot)10.00 (+34.62%)11.64 (85.94%)✅ (view plot)37.00 (+0.82%)38.48 (96.16%)
client_sv2_handle_message_mining✅ (view plot)8,219.00 (+0.23%)8,329.95 (98.67%)✅ (view plot)2,137.00 (+0.39%)2,169.96 (98.48%)✅ (view plot)3,159.00 (+0.39%)3,213.48 (98.30%)✅ (view plot)39.00 (+1.03%)43.29 (90.08%)✅ (view plot)139.00 (+0.09%)141.76 (98.06%)
client_sv2_mining_message_submit_standard✅ (view plot)6,282.00 (+0.09%)6,380.74 (98.45%)✅ (view plot)1,750.00 (+0.02%)1,762.20 (99.31%)✅ (view plot)2,547.00 (-0.22%)2,573.81 (98.96%)✅ (view plot)26.00 (+37.99%)26.89 (96.67%)✅ (view plot)103.00 (-0.67%)106.61 (96.61%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,657.00 (-0.65%)15,015.54 (97.61%)✅ (view plot)4,694.00 (+0.01%)4,706.20 (99.74%)✅ (view plot)6,752.00 (-0.03%)6,773.46 (99.68%)✅ (view plot)55.00 (+13.38%)55.94 (98.31%)✅ (view plot)218.00 (-1.63%)229.62 (94.94%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,465.00 (-0.03%)27,811.64 (98.75%)✅ (view plot)10,585.00 (+0.34%)10,587.11 (99.98%)✅ (view plot)15,400.00 (+0.33%)15,402.31 (99.99%)✅ (view plot)89.00 (+5.12%)91.60 (97.16%)✅ (view plot)332.00 (-0.68%)344.33 (96.42%)
client_sv2_open_channel✅ (view plot)4,417.00 (-1.41%)4,603.96 (95.94%)✅ (view plot)1,461.00 (+0.05%)1,473.48 (99.15%)✅ (view plot)2,157.00 (+0.17%)2,172.33 (99.29%)✅ (view plot)11.00 (-6.98%)14.92 (73.73%)✅ (view plot)63.00 (-2.77%)68.03 (92.60%)
client_sv2_open_channel_serialize✅ (view plot)14,006.00 (-1.25%)14,461.15 (96.85%)✅ (view plot)5,064.00 (+0.01%)5,076.48 (99.75%)✅ (view plot)7,321.00 (+0.04%)7,338.27 (99.76%)✅ (view plot)42.00 (+10.48%)43.69 (96.13%)✅ (view plot)185.00 (-3.00%)199.10 (92.92%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,557.00 (-0.29%)22,987.37 (98.13%)✅ (view plot)8,027.00 (+0.45%)8,029.42 (99.97%)✅ (view plot)11,672.00 (+0.42%)11,675.66 (99.97%)✅ (view plot)84.00 (+12.00%)86.37 (97.25%)✅ (view plot)299.00 (-1.51%)314.34 (95.12%)
client_sv2_setup_connection✅ (view plot)4,659.00 (-0.70%)4,760.41 (97.87%)✅ (view plot)1,502.00 (+0.05%)1,514.48 (99.18%)✅ (view plot)2,274.00 (-0.10%)2,297.62 (98.97%)✅ (view plot)15.00 (+49.76%)16.15 (92.87%)✅ (view plot)66.00 (-2.35%)69.76 (94.62%)
client_sv2_setup_connection_serialize✅ (view plot)15,942.00 (-1.68%)16,538.19 (96.40%)✅ (view plot)5,963.00 (+0.01%)5,975.48 (99.79%)✅ (view plot)8,662.00 (+0.07%)8,677.60 (99.82%)✅ (view plot)49.00 (+8.13%)50.53 (96.96%)✅ (view plot)201.00 (-4.04%)219.22 (91.69%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,416.00 (-0.27%)35,737.06 (99.10%)✅ (view plot)14,855.00 (+0.25%)14,857.31 (99.98%)✅ (view plot)21,811.00 (+0.23%)21,814.12 (99.99%)✅ (view plot)110.00 (+8.62%)115.71 (95.06%)✅ (view plot)373.00 (-1.43%)385.69 (96.71%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jul 16, 2024

🐰Bencher

ReportTue, July 16, 2024 at 15:41:15 UTC
ProjectStratum v2 (SRI)
Branchsplit-mg-ci-jobs
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,504.00 (+0.69%)8,715.43 (97.57%)✅ (view plot)3,746.00 (+0.13%)3,847.01 (97.37%)✅ (view plot)5,249.00 (+0.07%)5,389.61 (97.39%)✅ (view plot)7.00 (-10.78%)10.26 (68.20%)✅ (view plot)92.00 (+1.87%)94.23 (97.63%)
get_submit✅ (view plot)95,475.00 (-0.07%)96,085.16 (99.36%)✅ (view plot)59,439.00 (-0.04%)59,749.94 (99.48%)✅ (view plot)85,360.00 (-0.05%)85,796.32 (99.49%)✅ (view plot)49.00 (-9.59%)62.39 (78.54%)✅ (view plot)282.00 (-0.02%)287.23 (98.18%)
get_subscribe✅ (view plot)7,957.00 (-0.20%)8,243.84 (96.52%)✅ (view plot)2,841.00 (+0.33%)2,932.96 (96.86%)✅ (view plot)3,972.00 (+0.39%)4,091.28 (97.08%)✅ (view plot)13.00 (-17.24%)19.78 (65.72%)✅ (view plot)112.00 (-0.45%)116.54 (96.11%)
serialize_authorize✅ (view plot)12,257.00 (+0.36%)12,488.44 (98.15%)✅ (view plot)5,317.00 (+0.09%)5,418.01 (98.14%)✅ (view plot)7,412.00 (+0.05%)7,552.95 (98.13%)✅ (view plot)10.00 (-6.74%)13.23 (75.58%)✅ (view plot)137.00 (+0.92%)140.17 (97.74%)
serialize_deserialize_authorize✅ (view plot)24,554.00 (+0.29%)24,709.79 (99.37%)✅ (view plot)9,898.00 (-0.02%)10,015.78 (98.82%)✅ (view plot)13,959.00 (-0.05%)14,135.19 (98.75%)✅ (view plot)33.00 (-8.53%)41.37 (79.76%)✅ (view plot)298.00 (+0.91%)298.87 (99.71%)
serialize_deserialize_handle_authorize✅ (view plot)30,297.00 (+0.42%)30,381.58 (99.72%)✅ (view plot)12,101.00 (+0.04%)12,202.01 (99.17%)✅ (view plot)17,117.00 (-0.00%)17,266.95 (99.13%)✅ (view plot)60.00 (+1.85%)64.40 (93.17%)✅ (view plot)368.00 (+0.96%)368.80 (99.78%)
serialize_deserialize_handle_submit✅ (view plot)126,406.00 (-0.00%)126,977.72 (99.55%)✅ (view plot)73,224.00 (-0.03%)73,587.04 (99.51%)✅ (view plot)104,946.00 (-0.04%)105,464.50 (99.51%)✅ (view plot)120.00 (-0.36%)130.34 (92.07%)✅ (view plot)596.00 (+0.18%)598.97 (99.50%)
serialize_deserialize_handle_subscribe✅ (view plot)27,495.00 (+0.14%)27,593.39 (99.64%)✅ (view plot)9,643.00 (+0.10%)9,734.96 (99.06%)✅ (view plot)13,640.00 (+0.11%)13,766.61 (99.08%)✅ (view plot)62.00 (-4.98%)73.24 (84.66%)✅ (view plot)387.00 (+0.30%)388.48 (99.62%)
serialize_deserialize_submit✅ (view plot)114,999.00 (-0.06%)115,598.18 (99.48%)✅ (view plot)68,001.00 (-0.07%)68,369.30 (99.46%)✅ (view plot)97,559.00 (-0.08%)98,101.67 (99.45%)✅ (view plot)65.00 (-5.46%)75.09 (86.56%)✅ (view plot)489.00 (+0.15%)492.22 (99.34%)
serialize_deserialize_subscribe✅ (view plot)22,888.00 (+0.05%)23,093.82 (99.11%)✅ (view plot)8,195.00 (+0.09%)8,290.13 (98.85%)✅ (view plot)11,543.00 (+0.10%)11,672.90 (98.89%)✅ (view plot)36.00 (-7.47%)43.87 (82.07%)✅ (view plot)319.00 (+0.14%)321.34 (99.27%)
serialize_submit✅ (view plot)99,792.00 (-0.09%)100,413.31 (99.38%)✅ (view plot)61,483.00 (-0.04%)61,798.88 (99.49%)✅ (view plot)88,207.00 (-0.04%)88,649.31 (99.50%)✅ (view plot)49.00 (-10.43%)62.51 (78.38%)✅ (view plot)324.00 (-0.17%)328.76 (98.55%)
serialize_subscribe✅ (view plot)11,294.00 (-0.23%)11,579.92 (97.53%)✅ (view plot)4,188.00 (+0.23%)4,279.96 (97.85%)✅ (view plot)5,829.00 (+0.25%)5,950.14 (97.96%)✅ (view plot)15.00 (-7.23%)18.76 (79.96%)✅ (view plot)154.00 (-0.65%)159.34 (96.65%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash force-pushed the split-mg-ci-jobs branch 3 times, most recently from 25f6e3d to c68838e Compare July 16, 2024 13:33
@plebhash plebhash marked this pull request as draft July 16, 2024 13:35
@plebhash plebhash force-pushed the split-mg-ci-jobs branch 3 times, most recently from 3fb3fdd to d85bc50 Compare July 16, 2024 14:19
@pavlenex pavlenex linked an issue Jul 16, 2024 that may be closed by this pull request
@plebhash plebhash force-pushed the split-mg-ci-jobs branch 3 times, most recently from e2dbc76 to 4113fe6 Compare July 16, 2024 14:50
@plebhash plebhash marked this pull request as ready for review July 16, 2024 14:57
this is a paliative solution to stratum-mining#1028

we make MG CI slightly less worse by breaking tests into multiple jobs and allowing us to re-run false alarms in a more agile way

MG Tests are also separated from Tarpaulin
@GitGab19 GitGab19 merged commit 6f80d04 into stratum-mining:dev Jul 17, 2024
30 checks passed
@GitGab19 GitGab19 mentioned this pull request Jul 17, 2024
@plebhash plebhash deleted the split-mg-ci-jobs branch July 17, 2024 12:26
@plebhash plebhash mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MG CI is too slow
2 participants