Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.rs: Add support for finding header paths with pkg-config #952

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

francis-starlab
Copy link

@francis-starlab francis-starlab commented Dec 11, 2024

This MR is a follow up from: stratis-storage/libblkid-rs#171

The minimum version chose is from 2018, and I tested I could build against said version.

This can help in cross-compilation scenarios as well as large
complex builds.
@francis-starlab
Copy link
Author

I force pushed to fix a CI formatting issue.

@jbaublitz
Copy link
Member

@mulkieran Any objections to merging this?

@mulkieran mulkieran merged commit 90301a3 into stratis-storage:master Dec 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done(3)
Development

Successfully merging this pull request may close these issues.

3 participants