Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up build process #2

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

Convly
Copy link
Member

@Convly Convly commented Nov 22, 2024

Summary

Introduces several enhancements and configurations to ensure a robust development workflow for the project.

The changes include setting up TypeScript checks during pre-commit, configuring Rollup for building the project, and integrating ESLint with improved rules and TypeScript support.

Changes Overview

1. Pre-Commit TypeScript Checks

  • File Updated: .husky/pre-commit
  • Details: Added a TypeScript type-check command that runs before each commit to ensure any type errors are caught early.

The command can be run manually with

  pnpm run ts:check

2. Rollup Build Configuration

  • Files Updated: package.json, new rollup.config.mjs
  • Details:
    • Introduced scripts for building and cleaning (build, build:clean, clean), and watching (watch) files.
    • Added Rollup configuration to bundle TypeScript files into multiple module formats (CommonJS and ESM).
    • Updated tsconfig.json to implement necessary changes

3. ESLint Setup and Configuration

  • Files Updated: package.json, Replaced .eslintrc.js with new eslint.config.js
  • Details:
    • Integrated ESLint with TypeScript support using @typescript-eslint/parser.
    • Added eslint-plugin-import for managing import syntax and order.
    • Configured several linting rules to maintain code quality and consistency.

@Convly Convly added pr: chore Cleanups / dependencies / tooling / styling source: sdk-js labels Nov 22, 2024
@Convly Convly requested a review from innerdvations November 22, 2024 16:58
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, everything else seems to work great

@innerdvations innerdvations self-requested a review November 25, 2024 10:03
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, checked again and works for me!

@Convly Convly merged commit 0e71deb into chore/scaffold-project Nov 25, 2024
@Convly Convly deleted the chore/build-setup branch November 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore Cleanups / dependencies / tooling / styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants