feat: add renderer component #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
suggested changes
Oct 26, 2023
There was a problem hiding this comment.
Just an idea about your tests, it's not wrong doing tests for each part – but do you think because at the end they all end up being imported by BlockRenderer, would it be more beneficial to write a comprehensive integration suite for BlockRenderer only? it might save time and be clearer because you could focus on the API it presents rendering different schema sets etc.
Overall looks good though ⭐
|
Thanks for the reviews, looks like I have work to do on Monday 😅 |
Move exports to end of files Fix void nodes Move modifier type to Text file Remove wrapper div Rename type Rename block prop types
joshuaellis
suggested changes
Oct 31, 2023
remidej
changed the title
madhurisandbhor
approved these changes
Nov 2, 2023
joshuaellis
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Sets up the basic renderer logic and tests.
Handling the keys (not using indexes) will come in another PR as I want to focus on the essentials before adding complexity.
How to test it
You can try using the BlocksRenderer component in a react application, and give it the reponse of a Strapi app for a blocks field.
You can also verify that it matches our internal RFC for the renderer