feat: add simulator test wiring #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Reecepbcups I can't assign you as a reviewer. Commenting for visibility. |
Reecepbcups
requested changes
Jun 26, 2024
Comment on lines
+95
to
+96
| err = simtestutil.CheckExportSimulation(app, config, simParams) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
I am getting a invalid height: 2; expected: 1 error on tokenfactory/app/sim_test.go:97 for all the test
Starting the simulation from time Sun May 21 15:21:12 UTC 2248 (unixtime 8785034472)
Simulating... block 1/500, operation 300/332. sim_test.go:97:
Error Trace: /home/reece/Desktop/Programming/Go/tokenfactory/app/sim_test.go:97
Error: Received unexpected error:
invalid height: 2; expected: 1
go test -timeout 3000s -run ^TestFullAppSimulation$ github.com/strangelove-ventures/tokenfactory/app -v -Enabled
Maybe something with config.InitialBlockHeight ? or if simErr needs to just be checked selectively if some simParams or app value is set
There was a problem hiding this comment.
This is a known CosmosSDK issue. See cosmos/cosmos-sdk#20592.
Try running with -Commit=true
There was a problem hiding this comment.
cool ty! updated the summary. Leaving this as unresolved for future context
Reecepbcups
approved these changes
Jun 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Summaryt
This PR fixes the existing simulator cases and adds simulator test wiring.
All tests pass except
TestAppImportExportlike in strangelove-ventures/poa#186Not sure why.
Run
go test -timeout 3000s -run ^TestFullAppSimulation$ github.com/strangelove-ventures/tokenfactory/app -v -Enabled -Commit=true