Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ParamChangeProposal #467

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Adds ParamChangeProposal #467

merged 2 commits into from
Mar 31, 2023

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Mar 30, 2023

Closes #464 . Targeting v4 branch here

Question

  • Once approved, should I make another PR targeting main?

Changes

  • Adds a way to query a subspace param
  • ParamChangeProposal
  • Example test in action

Reason

@Reecepbcups Reecepbcups requested a review from a team as a code owner March 30, 2023 16:42
@Reecepbcups Reecepbcups requested review from joeabbey and removed request for a team March 30, 2023 16:42
Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the example!

@agouin agouin merged commit 5d08aab into strangelove-ventures:v4 Mar 31, 2023
@boojamya
Copy link
Contributor

Nice! @Reecepbcups
Pushing to main would be helpful.
v3 branch too would be a bonus (for noble).

boojamya pushed a commit that referenced this pull request Mar 31, 2023
* bump sdk to latest v45

* Adds ParamChange from #467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants