Extract relayer.DockerRelayer from rly.CosmosRelayer #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wrapper type will allow a minimal definition of the hermes relayer, or potentially any other relayer implementation, running inside Docker. This will also be helpful if we end up having to support different versions of rly or hermes that have a different CLI API.
DavidNix
approved these changes
May 25, 2022
| func (commander) GetConnections(chainID, homeDir string) []string { | ||
| return []string{ | ||
| "rly", "q", "connections", chainID, | ||
| "--home", homeDir, |
|
@joeabbey has been studying the differences between the CLI for rly and hermes, so I am going to wait for his review before merging this one, so that we can be more sure the DockerRelayer type can handle both relayers. |
joeabbey
approved these changes
May 31, 2022
…er-relayer And add CreateChannel method to DockerRelayer to satisfy the updated interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper type will allow a minimal definition of the hermes relayer,
or potentially any other relayer implementation, running inside Docker.
This will also be helpful if we end up having to support different
versions of rly or hermes that have a different CLI API.
For #3.