feat!: using ica controller instead of intertx #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller-instead-of-intertx
This reverts commit 2638272.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Reecepbcups
approved these changes
Apr 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* replacing intertx with interchain account controller * adding generic icatx support * updating SendICABankTransfer to use interchain account controller module * adding chain level wrappers for ica controller * go mod * Revert "go mod" This reverts commit 2638272. (cherry picked from commit 94f966a) # Conflicts: # chain/cosmos/chain_node.go # chain/cosmos/cosmos_chain.go
Reecepbcups
added a commit
that referenced
this pull request
Apr 17, 2024
…1074) * feat!: using ica controller instead of intertx (#1069) * replacing intertx with interchain account controller * adding generic icatx support * updating SendICABankTransfer to use interchain account controller module * adding chain level wrappers for ica controller * go mod * Revert "go mod" This reverts commit 2638272. (cherry picked from commit 94f966a) # Conflicts: # chain/cosmos/chain_node.go # chain/cosmos/cosmos_chain.go * fix changes in v7 from v8 --------- Co-authored-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interchain-accounts controllerinstead ofintertxmodule as it is deprecated.With the moving of the module features to module_modname.go, open to moving the ica features to
module_ica_controller.go