Dev #99
Merged
Dev #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For simplicity I start with synchronous client. There is an option to use asynchronous client, although the implementation is a bit more tricky.
Ignoring mypy type checking for socketio library as it does not define (and does not plan to) typing stubs.
TODO: enable Agent to make moves
The with block is important, thats how the websocket connection is automatically handled. It can be ommited by instiantiating the GeneralsIOClient directly, but it will require manual call for disconnect. For details, see: https://python-socketio.readthedocs.io/en/latest/client.html#creating-a-client-instance
GeneralsIO socket.io client
Will be usefull with map generation as player indexes are used to mark who ones given tile.
The game state saved in `map` and `cities` is initialized to an empty array. I am thinking that the patch method would at the first iteration push new items to an empty array. Although I am not sure whether it is the best approach as patch method should not have an if checking if it is the first time the patch function is called. Maybe we could create init function that would be called on the first update only? Ideally we would initialize the game states to appropriate size, unfortunatelly, sizes are propagated with the first `game_update`. If we used Python list then we don't have this problem as Python slices would handle that for us. Could numpy slice work as well?
.. and make it compatible with observations from simulator and generalsio
revolko
reviewed
Oct 24, 2024
generals/remote/generalsio_client.py
Outdated
| # convert to index | ||
| source_index = source[0] * self.game_state.map[0] + source[1] | ||
| destination_index = destination[0] * self.game_state.map[0] + destination[1] | ||
| self.emit("attack", (int(source_index), int(destination_index), int(split))) |
There was a problem hiding this comment.
that is just a presonal preferrence, but I would decouple sending the message from this method and move it to the _play_game method --> to have game message be handled in the single class.
There was a problem hiding this comment.
single class? you mean function?
There was a problem hiding this comment.
i think i see what you mean and it makes sense, will do that
There was a problem hiding this comment.
In a single method, sorry.
strakam
force-pushed
the
dev
branch
2 times, most recently
from
2722089 to
fb3d416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let me know what u think (ignore all files except client file and maybe observation)
Closes #94