Pre release finetuning #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdujava
reviewed
Oct 13, 2024
Comment on lines
+61
to
+66
| action = { | ||
| "pass": 0, | ||
| "cell": action[:2], | ||
| "direction": action[2], | ||
| "split": 0, | ||
| } |
There was a problem hiding this comment.
Is there a way to make action from valid_actions to also have "cell" and "direction"?
Now there are weird manipulations like action[:2] or action[:-1] to extract relevant data.
update workflow, solve mypy problems, update makefile, remove unused files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ladies and gentlemen,
this is hopefully the last PR before
v1.0.0🚀.If you have any comments, please let me know. One last thing that I want to do is to finalize examples from
README.mdand perhaps finetune introductory text.(For those who can, please don't merge this).