Registry creation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. also add AgentFactory
.. resolve errors from checks, improve examples, finish registry system
jdujava
reviewed
Oct 6, 2024
Puckoland
reviewed
Oct 6, 2024
| pass | ||
|
|
||
| @staticmethod | ||
| def make_agent(agent_type: str, **kwargs) -> Agent: |
There was a problem hiding this comment.
It might be nice to name it simply make. We know that it will make an agent since it is AgentFactory.
There was a problem hiding this comment.
true, will do in later updates, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentlemen,
I just wanted to tell you whats new:
gym.makeand users can create their own defaults viagym.register. Gym make is nice because it checks whether environment is working as it should (for example it caught that.reset()with fixed seed gave two different observations.AgentFactorythat will create agentsgym.check_env, so I removed themThis message is more important than the code, you don't need to look at the code changes.
Hopefully there will be only one more pull request before
v1.0-- the one showcasing how to use some RL framework for this game.Cheers 🚀