refactor: action to a subclass of ndarray for a clearer interface and consistent repr. #122
+87
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anordin95
force-pushed
the
refactor-action
branch
3 times, most recently
from
99d5c4a to
2919f48
Compare
… consistent repr.
anordin95
force-pushed
the
refactor-action
branch
from
2919f48 to
198116f
Compare
right on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clearer interface for Action & ensure a consistent representation (i.e. it's always an np.array with 5 int8's, not sometimes a list with some bools and some ints, etc.).
Note: I went with
np.int8rather thannp.uint8since the game-logic subtracts from the (row, col) fields sometimes resulting in -1.I also added a distinction between
moves&actionsand noted what it means in the docs.