Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix inconsistent thrust detection across the backends #92

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Feb 7, 2020

CUDA ships the thrust library by default. Since it lives in the same include directory as the CUDA headers, the detection for the CUDA backend implicitly works. However, this prevents pointing to another (e.g. more recent) version of thrust. Furthermore, no version check is performed to ensure that the requirements are fulfilled. Change that to find thrust for all backends consistently. In addition, explicitly set the device backend for thrust when using CUDA to make this consistent to the OpenMP backend and become independent of thrust's default backend choice.

@stotko stotko added the bug label Feb 7, 2020
@stotko stotko added this to the 1.3.0 milestone Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          27       27           
  Lines        1611     1611           
=======================================
  Hits         1576     1576           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfd3d3...df5dc59. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant