Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose occupied() in unordered map #436

Conversation

david-tingdahl-nvidia
Copy link

Useful when iterating over the whole hash and copying valid entries.

@stotko
Copy link
Owner

stotko commented Oct 30, 2024

Thanks for the feature request. The same change has also been proposed in #427 to address #423. As already mentioned there, I believe that publicly exposing the internal occupied() function is not the right design. Instead, device_range() should be used to iterate over the (compressed) set of values which is more efficient, especially at low load factors.

@stotko
Copy link
Owner

stotko commented Nov 20, 2024

The problems concerning incomplete stream support has been fixed in #450. Exposing the internal occupancy status should thus not be necessary in general. Feel free to open an issue if this did not address your use case.

@stotko stotko closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants