Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranges: Fix compilation 64-bit index type #157

Merged
merged 1 commit into from
May 10, 2020
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented May 10, 2020

In #102, a index64_t constructor has been added to the ranges classes and the old index_t constructors have been deprecated. However, if the latter coincides with the former, i.e. STDGPU_USE_32_BIT_INDEX is set to OFF, this results in compilation errors due to rereclarations and redefinitions. Fix this error by conditionally enabling the deprecated index_t version.

@stotko stotko added the bug label May 10, 2020
@stotko stotko added this to the 1.3.0 milestone May 10, 2020
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          28       28           
  Lines        1705     1705           
=======================================
  Hits         1665     1665           
  Misses         40       40           
Impacted Files Coverage Δ
src/stdgpu/impl/ranges_detail.h 100.00% <ø> (ø)
src/stdgpu/ranges.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a8350...519c41e. Read the comment docs.

@stotko stotko merged commit 93ef044 into master May 10, 2020
@stotko stotko deleted the ranges_64_bit_index_fix branch May 10, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant