compiler,plaform: Use unique numbers as internal macro definitions #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 28 28
Lines 1698 1698
=======================================
Hits 1658 1658
Misses 40 40 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros in the
compilerandplatformare implemented through magic numbers to distinguish the individual values. However, the ranges of many different groups of macros overlap which leads to unexpected behavior if mixing them up. Use unique identifiers for all valued macros. This fixing potential weird behavior in such cases.Note that mixing up macros is a bug itself and needs to be fixed. This change helps to unveil such erroneous cases.