Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: Fix readability-implicit-bool-conversion warnings #134

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 16, 2020

limits exploits the fact that boolean values may implicitly be converted to 1 and 0 integer values. This is useful for computing the number of digits for types that may be signed or unsigned such as char and wchar_t. Fix the related clang-tidy warnings by explicitly casting the boolean values to integers making this intentional usage clear.

@stotko stotko added the bug label Apr 16, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   97.57%   97.69%   +0.11%     
==========================================
  Files          28       28              
  Lines        1694     1694              
==========================================
+ Hits         1653     1655       +2     
+ Misses         41       39       -2     
Impacted Files Coverage Δ
src/stdgpu/impl/limits_detail.h 100.00% <ø> (ø)
src/stdgpu/impl/unordered_base_detail.cuh 96.74% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69aa426...f556a40. Read the comment docs.

@stotko stotko merged commit 560ae32 into master Apr 16, 2020
@stotko stotko deleted the warnings_implicit_bool_conversions branch April 16, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant