Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix hicpp-use-override warnings #130

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 16, 2020

The recently added clang-tidy emits hicpp-use-override warnings for our test code. Fix these trivial issues.

@stotko stotko added the bug label Apr 16, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 16, 2020
@stotko stotko force-pushed the warnings_use_override branch from f68bf11 to 6078896 Compare April 16, 2020 09:12
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          28       28           
  Lines        1685     1685           
=======================================
  Hits         1650     1650           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4ed7d...6078896. Read the comment docs.

@stotko stotko merged commit c7bc5fa into master Apr 16, 2020
@stotko stotko deleted the warnings_use_override branch April 16, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant