Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prettier warning #9748

Merged
merged 1 commit into from
Feb 4, 2020
Merged

fix prettier warning #9748

merged 1 commit into from
Feb 4, 2020

Conversation

sakit0
Copy link
Contributor

@sakit0 sakit0 commented Feb 4, 2020 •
edited
Loading

What I did

When you do storybook/lib/core/src/server/common/babel.js 8:24 warning Insert , prettier/prettier yarn lint .

fixed prettier.

@sakit0 sakit0 changed the title fix prettier Insert fix prettier warning Feb 4, 2020
@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Feb 4, 2020
shilman
shilman approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 4, 2020
@shilman shilman merged commit bc416f9 into storybookjs:master Feb 4, 2020
@sakit0 sakit0 deleted the fix/lint-prettier branch February 5, 2020 01:29
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 13, 2020
@lili2311 lili2311 mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakit0 @shilman