-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source-loader: Disable no-implicit-any linting #9272
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/7n6kqadkc |
Self-merging @libetl @tmeasday @ndelangen |
@shilman I was looking at you fix and have the impression that the rule that you have added only works for eslint parser. Since awesome-typescript-loader works only with TypeScript ^2.0 and Webpack ^2.0, my idea is to add an |
@JacopoBonta there's already a |
@shilman lol, forget it |
I'm thinking maybe the error is coming from outside of the block 😭 since more code is getting inserted in other parts of the file. |
Hi It seems that this change produces some warning:
Where does this rule come from? When I look at the typescript-eslint rules I don't find any |
@simonhoss Ugh you're right. I'll revert this. 😭 |
Issue: #7829
What I did
When source-loader is misconfigured to run before linting (why? i'm not sure), it generates a no-implicit-any error. This change attempts to disable that.
How to test
Not exactly sure about the setup that generates this