Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-loader: Disable no-implicit-any linting #9272

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 30, 2019

Issue: #7829

What I did

When source-loader is misconfigured to run before linting (why? i'm not sure), it generates a no-implicit-any error. This change attempts to disable that.

How to test

Not exactly sure about the setup that generates this

@vercel
Copy link

vercel bot commented Dec 30, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/7n6kqadkc
✅ Preview: https://monorepo-git-7829-source-loader-no-implicit-any.storybook.now.sh

@shilman shilman added this to the 5.3.0 milestone Dec 30, 2019
@shilman shilman changed the title Source-loader: Disable no-impliicit-any linting Source-loader: Disable no-implicit-any linting Dec 30, 2019
@shilman
Copy link
Member Author

shilman commented Dec 30, 2019

Self-merging @libetl @tmeasday @ndelangen

@shilman shilman merged commit 0870b23 into next Dec 30, 2019
@shilman shilman deleted the 7829-source-loader-no-implicit-any branch December 30, 2019 19:27
@JacopoBonta
Copy link

@shilman I was looking at you fix and have the impression that the rule that you have added only works for eslint parser. Since awesome-typescript-loader works only with TypeScript ^2.0 and Webpack ^2.0, my idea is to add an // @ts-ignore to disable any linting operation by the at-loader.
It's just an idea, not sure it could work. What do you think?
ps: @ts-ignore doesn't work for blocks -> https://stackoverflow.com/questions/51145180/how-to-use-ts-ignore-for-a-block

@shilman
Copy link
Member Author

shilman commented Dec 31, 2019

@JacopoBonta there's already a // @ts-ignore before each line of the block

@JacopoBonta
Copy link

@shilman lol, forget it

@shilman
Copy link
Member Author

shilman commented Dec 31, 2019

I'm thinking maybe the error is coming from outside of the block 😭 since more code is getting inserted in other parts of the file.

@simonhoss
Copy link

simonhoss commented Jan 6, 2020

Hi

It seems that this change produces some warning:

Definition for rule '@typescript-eslint/no-implicit-any' was not found

Where does this rule come from? When I look at the typescript-eslint rules I don't find any no-implicit-any rule https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin

@shilman
Copy link
Member Author

shilman commented Jan 6, 2020

@simonhoss Ugh you're right. I'll revert this. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants