Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source-loader: Selectively ignore typescript errors in generated code #7845

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Source-loader: Selectively ignore typescript errors in generated code #7845

merged 1 commit into from
Aug 23, 2019

Conversation

enagy27
Copy link
Contributor

@enagy27 enagy27 commented Aug 22, 2019 •
edited by shilman
Loading

Issue: #7829

What I did

Converted // @ts-ignore-start and // @ts-ignore-end to line-by-line ignores

How to test

  • Start storybook in --docs mode on beta.39 with a Typescript story

@vercel
Copy link

vercel bot commented Aug 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@enagy27
Copy link
Contributor Author

enagy27 commented Aug 22, 2019

@shilman any pointers on running this on my system? I'm guessing I can build and link but I'm not sure which pieces I need to link

@enagy27 enagy27 closed this Aug 22, 2019
@shilman shilman reopened this Aug 23, 2019
@shilman shilman added this to the 5.2.0 milestone Aug 23, 2019
@shilman shilman merged commit 6a414d9 into storybookjs:next Aug 23, 2019
@shilman shilman mentioned this pull request Aug 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug source-loader
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@enagy27 @shilman