Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forked CRA support on Windows #6235

Closed
wants to merge 1 commit into from
Closed

Forked CRA support on Windows #6235

wants to merge 1 commit into from

Conversation

sergeyzwezdin
Copy link
Contributor

Issue: Support for CRA fork packages on Windows (#5801)

What I did

I've added parsing of .bin/react-scripts file to find out actual react-scripts package path.

@sergeyzwezdin sergeyzwezdin mentioned this pull request Mar 22, 2019
Closed
shilman
shilman requested changes Mar 22, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. However, we generally receive PRs on the next branch, release them in alpha and then cherry-pick them back into master after they've been used a bit. Would you mind targeting this PR at next instead?

Also, were you able to test this out?

@sergeyzwezdin
Copy link
Contributor Author

@shilman Sounds reasonable. I've re-created PR #6236. Thank you!

@sergeyzwezdin
Copy link
Contributor Author

@shilman as for testing - I've just tested it on our fork - works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman requested changes

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyzwezdin @shilman