Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte support #3770

Merged
merged 98 commits into from
Aug 9, 2018
Merged
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
1381b93
Basic Svelte support
plumpNation Jun 16, 2018
40660ea
Added knob addon example
plumpNation Jun 17, 2018
306b580
Centered addon working with Svelte
plumpNation Jun 17, 2018
5f64ea3
Added background addon support
plumpNation Jun 17, 2018
f64ec68
Added support for actions addon
plumpNation Jun 17, 2018
295f4e2
Easier to see the centering when we break the sentences
plumpNation Jun 17, 2018
adabc88
Updating root README with svelte links
plumpNation Jun 17, 2018
9acf5f5
File not required
plumpNation Jun 17, 2018
ce09ea7
No longer using this file for svelte, refactor not required for review
plumpNation Jun 17, 2018
cf72ffd
File not required
plumpNation Jun 17, 2018
ba11d16
File was changed by accident
plumpNation Jun 17, 2018
cecc676
referencing incorrect app
plumpNation Jun 17, 2018
bab002e
File not required
plumpNation Jun 17, 2018
0eed975
Add jest support for svelte files
plumpNation Jun 17, 2018
a677702
Svelte stories don't support these addons yet
plumpNation Jun 17, 2018
43b3660
linting and using global document
plumpNation Jun 17, 2018
1035614
Unnecessary code
plumpNation Jun 17, 2018
e65573e
Creating svelte test and integration locations to match vue
plumpNation Jun 17, 2018
3dbe010
incorrect app name
plumpNation Jun 17, 2018
43986fb
Remove experimental code
plumpNation Jun 17, 2018
037187e
Should use the same styles as all the other frameworks
plumpNation Jun 17, 2018
09ca251
Overwriting internal methods is an antipattern
plumpNation Jun 17, 2018
75e1fd4
Missing function to export
plumpNation Jun 17, 2018
0f4f756
Added addon link example
plumpNation Jun 17, 2018
0228962
Added addon notes example
plumpNation Jun 18, 2018
3844c54
Wrapping up the mount in a named function
plumpNation Jun 18, 2018
27104f8
Viewport addon support added
plumpNation Jun 18, 2018
03c6c0c
Readded addon options support
plumpNation Jun 18, 2018
63f09e0
Framework support lists should be in chronological order
plumpNation Jun 19, 2018
0afd157
Guide was quite wrong in places
plumpNation Jun 19, 2018
17cb74f
Build works fine in kitchen sink without peer deps, afaict
plumpNation Jun 19, 2018
bad4b31
We are not just returning a component
plumpNation Jun 19, 2018
1a4cc60
local eslint config not required
plumpNation Jun 19, 2018
15ee3c6
Since yarn seems to be the package manager of choice
plumpNation Jun 19, 2018
ef2e19c
I wish I'd known this at the start.
plumpNation Jun 19, 2018
a7dd460
I think this project recommends yarn
plumpNation Jun 19, 2018
284a443
Editing the welcome text a little
plumpNation Jun 19, 2018
2f8a3ad
Title meant nothing
plumpNation Jun 19, 2018
edd4770
npm to yarn, and commands were likely wrong
plumpNation Jun 19, 2018
3ca5be1
Starting to reduce the complexity of the example
plumpNation Jun 19, 2018
f5e5c62
Stories had misleading details
plumpNation Jun 19, 2018
02bc696
Tested story source addon
plumpNation Jun 19, 2018
05f01ad
This is not necessarily just a svelte helper
plumpNation Jun 19, 2018
cf7b724
Less confusing to follow the same property names as styles.json
plumpNation Jun 19, 2018
e33d5f2
Snapshots were not being rendered, so were useless
plumpNation Jun 24, 2018
a953fce
I am not making a good point
plumpNation Jun 24, 2018
35b477f
Storyshot support marked as supported
plumpNation Jun 24, 2018
042ca5d
Tidying up the centered addon functionality and adding comments
plumpNation Jun 24, 2018
63b568f
Trying to be clearer in snapshot markup explanation
plumpNation Jun 24, 2018
e84768b
Added unit test for example component
plumpNation Jun 24, 2018
ef4a5eb
Merge branch 'master' into svelte-support
Hypnosphi Jun 26, 2018
33006b8
Teamcity: Build for svelte
Hypnosphi Jun 26, 2018
28a4bef
Teamcity: Remove duplicate
Hypnosphi Jun 26, 2018
73f5951
Merge branch 'master' into svelte-support
Hypnosphi Jun 28, 2018
b2912e7
Merge branch 'master' into svelte-support
Hypnosphi Jun 28, 2018
157a580
fix actions not working with centered
ekhaled Jul 23, 2018
bed1a50
cleanup wrapper when available
ekhaled Jul 23, 2018
b848466
Added my name to the CODEOWNERS file
plumpNation Jul 24, 2018
c636cb5
This seems unnecessary
plumpNation Jul 24, 2018
82f8119
Need to clean up previous manually added events on rerender
plumpNation Jul 24, 2018
ec832b4
Updating deps to alpha 10
plumpNation Jul 24, 2018
fb333e2
Merge branch 'svelte-support' into further-svelte-support-help
ekhaled Jul 24, 2018
2282813
Behaviour when onclick was not explicit enough
plumpNation Jul 24, 2018
59ce0d9
Missing reference to myself
plumpNation Jul 24, 2018
2bc8353
Confusing label on button referencing incorrect location.
plumpNation Jul 24, 2018
dd1e609
Componnents must be destroyed when mounting a new story to clean up a…
plumpNation Jul 24, 2018
cabb323
Merge branch 'svelte-support' into further-svelte-support-help
plumpNation Jul 24, 2018
2c8b958
Merge pull request #1 from ekhaled/further-svelte-support-help
plumpNation Jul 24, 2018
57c24b3
Merge branch 'master' into svelte-support
plumpNation Jul 25, 2018
1b46de2
4.0.0-alpha.14
plumpNation Jul 25, 2018
6096035
Added env setup to honour #3744
plumpNation Jul 25, 2018
7fc81d9
Added example for centred with actions
plumpNation Jul 25, 2018
b5bd22b
Updating snapshots
plumpNation Jul 25, 2018
06b0ac7
Aligning unit test to updated Button component textContent
plumpNation Jul 25, 2018
d842cea
Note is not relevant to bold text, rather to the ButtonView
plumpNation Jul 25, 2018
9a4e2db
Missing svelte editor config
plumpNation Jul 25, 2018
209ae29
Svelte missing from autolabeler
plumpNation Jul 25, 2018
dc2beac
Svelte missing from markdown spell check
plumpNation Jul 25, 2018
f79c35b
Svelte community uses both svelte and html extensions
plumpNation Jul 25, 2018
f41eb61
Missing centered documentation for Svelte
plumpNation Jul 25, 2018
450e4a6
Missing links to svelte guides and examples in docs
plumpNation Jul 25, 2018
5c3dbf2
Running svelte tests was undocumented in CONTRIBUTING guide
plumpNation Jul 25, 2018
57f1b09
Contributors should have a clear list of ideas to work on
plumpNation Jul 25, 2018
b97bb40
Another todo suggestion added and list checkbox formatted
plumpNation Jul 26, 2018
13d09e6
Merge remote-tracking branch 'origin/master' into svelte-support
igor-dv Jul 30, 2018
c94f632
Commit something to trigger full netlify build
igor-dv Jul 30, 2018
9464939
Update CLI
igor-dv Jul 30, 2018
c173e40
Merge remote-tracking branch 'origin/master' into svelte-support
igor-dv Aug 1, 2018
846ed34
Remove badges and docs
igor-dv Aug 1, 2018
c60fe16
Move Svelte to the end of the list for the chronology
igor-dv Aug 1, 2018
37c1f5f
Add missing svelte-kitchen-sink in built-storybooks
igor-dv Aug 2, 2018
0b9f38a
Update CLI
igor-dv Aug 2, 2018
70b4dd1
Merge branch 'master' into svelte-support
ndelangen Aug 6, 2018
0fffe6e
Bring "tslint-plugin-prettier" back
igor-dv Aug 6, 2018
86afcac
FIX versions in package.json
ndelangen Aug 6, 2018
2a5e762
Delete false symlink =/
igor-dv Aug 7, 2018
60ff6ab
Added symlink to svelte example
tmeasday Aug 9, 2018
fb28658
fix svelte symlink
tmeasday Aug 9, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added example for centred with actions
plumpNation committed Jul 25, 2018
commit 7fc81d966d4ab4b15b16eeb1d063f80a1ee70ae9
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { storiesOf } from '@storybook/svelte';
import Centered from '@storybook/addon-centered/svelte';
import { action } from '@storybook/addon-actions';

import Button from '../components/Button.svelte';

@@ -11,4 +12,10 @@ storiesOf('Addon|Centered', module)
rounded: true,
text: "Look, I'm centered!",
},
}))
.add('with action', () => ({
Component: Button,
on: {
click: action(`Tell me it ain't so! Centered and with actions! Thanks @ekhaled :)`),
},
}));