Add lang="en" to html element #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dropShadow and use the native font of the OS
It's fairly common for people having '.jsx' extensions for their react components.
We simply avoid building the manager code in the production build Uglifying, already uglified code takes a lot of time. We we avoid that by simply copying the manager code comes with React Storybook to the build output directly bypassing webpack.
These packages are required for the webpack to work properly.
Adds lang="en" to html elements in both the index and iframe
|
Perhaps this should be configurable? |
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced Dec 25, 2022
|
View your CI Pipeline Execution ↗ for commit d7b3b39.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lang="en" to html elements in both the index and iframe
I'm adding axe-core to my storybook, and one issue it always flags is that the
htmlelement lacks a validlangattribute. Seems reasonable to add that to Storybook upstream, so that it is only flagging accessibility issues in my own components. Thoughts?