Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Test: Only reset story count on file change when watch mode is enabled #30121

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Addon Test: Only reset story count on file change when watch mode is enabled #30121

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c1752
Only reset story count on file change when watch mode is enabled
ghengeveld Dec 20, 2024
7faee6d
Merge branch 'next' into test-count-reset-fix
ghengeveld Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/addons/test/src/node/vitest-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,14 @@ export class VitestManager {
const id = slash(file);
this.vitest?.logger.clearHighlightCache(id);
this.updateLastChanged(id);
this.storyCountForCurrentRun = 0;

// when watch mode is disabled, don't trigger any tests (below)
// but still invalidate the cache for the changed file, which is handled above
if (!this.testManager.config.watchMode) {
return;
}

this.storyCountForCurrentRun = 0;
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
await this.runAffectedTests(file);
}

Expand Down
Loading