Vite: Add extra entries to optimizeDeps
#30117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 5240a4a.
☁️ Nx Cloud last updated this comment at |
yannbf
approved these changes
Dec 20, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+20
to
+21
| '@storybook/addon-essentials/actions/preview', | ||
| '@storybook/addon-essentials/actions/preview', |
There was a problem hiding this comment.
logic: '@storybook/addon-essentials/actions/preview' is duplicated
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29812
What I did
I added more packages/files to our liost of
optimizeDeps. The entries i added we got from running mealdrop & inkline, as well as some logical deduction.It's not likely this list if 100% complete, and we might be unable to actually ensure it's 100% complete.
I also discussed with @JReinhold about the idea that individual addons and renderers should really be responsible for setting these themselves.
I'd be great if the underlaying issue (refreshes and flaky test runs) could be solved in some other way.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
@yannbf on his machine added these entries manually to his viteFinal config in mealdrop & inkline & module-mocking-demo, and verified that storybook no longer refreshes, and the re no messages in the command-line about missing optimizedDeps
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30117-sha-7ec361e1. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30117-sha-7ec361e1 sandboxor in an existing project withnpx storybook@0.0.0-pr-30117-sha-7ec361e1 upgrade.More information
0.0.0-pr-30117-sha-7ec361e1norbert/add-optimizedeps-prevent-reloads7ec361e11734697309)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30117Greptile Summary
Based on the provided information, I'll create a concise summary of the pull request:
Added numerous Storybook addon preview files and dependencies to Vite's optimizeDeps configuration to prevent hard reloads during dependency optimization.
mockdate,msw-storybook-addon, andchromatic/isChromatic@storybook/addon-essentials/actions/preview