Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Minor 8.4.0 #29498

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 31, 2024

This is an automated pull request that bumps the version from 8.4.0-beta.5 to 8.4.0.
Once this pull request is merged, it will trigger a new release of version 8.4.0.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.4.0

Greptile Summary

This appears to be an automated version bump PR from 8.4.0-beta.5 to 8.4.0. Here's my analysis of the key changes and concerns:

Version bump from beta to stable release with several notable features and improvements.

  • Empty changelog entry in PR body raises concerns about verification of included changes
  • Missing info.plain field in latest.json should contain release notes
  • No list of merged PRs/commits in PR body makes it impossible to verify appropriateness
  • Automated version bump appears to have correct version numbers across files
  • Core features like Vitest integration and Next.js-Vite framework suggest this warrants a minor version bump

The changes themselves appear appropriate for a minor release, but there are important process gaps that need to be addressed before merging. The maintainers should ensure proper documentation and verification of included changes.

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Oct 31, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 4 to 6
## 8.3.6

- CLI: Install Svelte CSF v5 in Svelte5 projects - [#29323](https://github.com/storybookjs/storybook/pull/29323), thanks @shilman!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Empty section between version header and previous version should contain release notes

@@ -1 +1 @@
{"version":"8.3.0","info":{"plain":""}}
{"version":"8.4.0","info":{"plain":""}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: info.plain field is empty but should contain release notes summarizing the changes in 8.4.0

@kasperpeulen kasperpeulen added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Oct 31, 2024
Copy link

nx-cloud bot commented Oct 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8710fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit ed68418 into next-release Oct 31, 2024
5 of 7 checks passed
@kasperpeulen kasperpeulen deleted the version-non-patch-from-8.4.0-beta.5 branch October 31, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants