-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Minor 8.4.0 #29498
Release: Minor 8.4.0 #29498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
## 8.3.6 | ||
|
||
- CLI: Install Svelte CSF v5 in Svelte5 projects - [#29323](https://github.com/storybookjs/storybook/pull/29323), thanks @shilman! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Empty section between version header and previous version should contain release notes
@@ -1 +1 @@ | |||
{"version":"8.3.0","info":{"plain":""}} | |||
{"version":"8.4.0","info":{"plain":""}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: info.plain field is empty but should contain release notes summarizing the changes in 8.4.0
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c8710fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This is an automated pull request that bumps the version from
8.4.0-beta.5
to8.4.0
.Once this pull request is merged, it will trigger a new release of version
8.4.0
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0
Greptile Summary
This appears to be an automated version bump PR from 8.4.0-beta.5 to 8.4.0. Here's my analysis of the key changes and concerns:
Version bump from beta to stable release with several notable features and improvements.
The changes themselves appear appropriate for a minor release, but there are important process gaps that need to be addressed before merging. The maintainers should ensure proper documentation and verification of included changes.