Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anedomansky/feat-angular-support-zoneless #28657

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

anedomansky
Copy link

Closes #28403

What I did

Added a the new "experimentalZoneless" flag in order to use the experimental zoneless change detection introduced in Angular 18.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@anedomansky
Copy link
Author

anedomansky commented Jul 19, 2024

Hi @valentinpalkovic

I tried to read the necessary information from the angular.json via the helper class "AngularJSON".
I still do not know if this is the right approach...
Other than that, I still have the open problem that I can not really import the "provideExperimentalZonelessChangeDetection" provider from "@angular/core" without updating the package and all related ones to their respective 18.X versions.
Can you perhaps enlighten me on how to progress from here?

Thanks!

@valentinpalkovic
Copy link
Contributor

I didn’t had a chance to take a look today. I’ll take a look on Monday and I will clarify what’s unclear! Thank you for putting together the PR so far :)

Copy link

nx-cloud bot commented Jul 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8cd70fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many -t build --parallel=3

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Angular: Support zoneless
2 participants