Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Optimize the bundle, remove duplicates #28571

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jul 12, 2024

Closes #

What I did

  Install size Packages added Lock file increase
storybook@~8.1 130M 596 5560 lines
storybook@~8.2 133M 470 4436 lines
toolbox split 72M 117 1186 lines
full CLI split 63M 101 1071 lines
optimize bundles (this PR) 48M 95 1030 lines

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28571-sha-b97df212. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28571-sha-b97df212 sandbox or in an existing project with npx storybook@0.0.0-pr-28571-sha-b97df212 upgrade.

More information
Published version 0.0.0-pr-28571-sha-b97df212
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/optimize-bundle
Commit b97df212
Datetime Fri Jul 12 14:03:55 UTC 2024 (1720793035)
Workflow run 9909148775

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28571

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/9909102176

Copy link

nx-cloud bot commented Jul 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ec9e0d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated import paths to use @storybook/core/csf-tools for consistency and optimization (code/core/src/core-server/server-channel/file-search-channel.ts, code/core/src/core-server/utils/save-story/save-story.ts, code/core/src/core-server/utils/warnWhenUsingArgTypesRegex.ts).
  • Added TypeScript types for Babel packages and included Prettier as an optional peer dependency (code/core/package.json).
  • Enhanced bundle analysis logic to generate individual reports for each bundle (code/core/scripts/prep.ts).
  • Introduced babelParseFile function for more powerful parsing capabilities (code/core/src/csf-tools/babelParse.ts).
  • Relocated and renamed multiple files to centralize parser logic and streamline the codebase (code/core/src/csf-tools/parser/*, code/core/src/csf-tools/save-story/*).

25 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@kasperpeulen kasperpeulen marked this pull request as draft July 12, 2024 14:22
Base automatically changed from kasper/cli-split to next August 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants