Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix close button label for accessibility in search edit field #28557

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

chidiebereojingwa
Copy link

Fix: Update close button label for accessibility in search edit field

Issue: The close/dismiss button in the search edit field does not have a proper name for screen readers.

Solution: Updated the title and aria-label attributes of the DismissButtonWrapper in the NotificationItem.tsx file to "Close search".

Testing

  • Verified the changes locally using a screen reader to ensure the button is announced correctly.

References:

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated title attribute of DismissButtonWrapper to "Close search"
  • Updated aria-label attribute of DismissButtonWrapper to "Close search"
  • Enhanced accessibility for screen readers in NotificationItem.tsx

File: /code/core/src/manager/components/notifications/NotificationItem.tsx

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@shilman shilman changed the title Fix: Update close button label for accessibility in search edit field UI: Fix close button label for accessibility in search edit field Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants