Don't mangle function names for production builds #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
=======================================
Coverage 34.35% 34.35%
=======================================
Files 390 390
Lines 8772 8772
Branches 911 916 +5
=======================================
Hits 3014 3014
- Misses 5136 5140 +4
+ Partials 622 618 -4
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jan 10, 2018
|
Thanks @pascalduez , totally makes sense |
|
Not sure if this should be applied to Angular, Vue builds as well. |
Hypnosphi
requested changes
Jan 10, 2018
pascalduez
force-pushed
the
feature/minify-nomangle-fn-names
branch
from
48a980d to
e5d29f2
Compare
pascalduez
changed the title
pascalduez
changed the title
|
@Hypnosphi Done. |
Hypnosphi
approved these changes
Jan 10, 2018
shilman
pushed a commit
that referenced
this pull request
Jan 13, 2018
…ames Don't mangle function names for production builds
Hypnosphi
added
patch:done
This was referenced Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Function names are mangled by UglifyJS during production build.
They are important for React stateless components, especially in a styleguide context such as Storybook. This allows playing nicely with third party libraries such as
react-element-to-jsx-string.The issue happened after #2530.
What I did
Passed the
compress: { keep_fnames: true }option to all production builds UglifyJS plugin.Did not noticed significant bundle size increase on our internal styleguide, which is quite large.
How to test
Is this testable with jest or storyshots? Nope
Does this need a new example in the kitchen sink apps? Nope
Does this need an update to the documentation? Nope
If your answer is yes to any of these, please make sure to include it in your PR.