Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.0.0-rc.2 #26290

Merged
merged 100 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
a4afdc7
chore(docs): fix glob pattern jest
naporin0624 Feb 9, 2024
11a8484
consolidate generate-sandboxes workflows into a single workflow and c…
JReinhold Feb 9, 2024
81abd2a
temporarily test this branch as for sandbox generation
JReinhold Feb 9, 2024
658f715
correct syntax for local composite actions
JReinhold Feb 9, 2024
a385574
correcterer composite action syntax
JReinhold Feb 9, 2024
871e1b1
correctest composite action syntax
JReinhold Feb 9, 2024
bb0d0d0
move secrets to workflow
JReinhold Feb 9, 2024
02f6241
use regular workflow instead of composite action
JReinhold Feb 9, 2024
f184601
Continue with publishing even if some sandboxes fail
JReinhold Feb 9, 2024
86c5895
Yet Another Maddening Language™
JReinhold Feb 9, 2024
1122215
randomly cause generation failures
JReinhold Feb 9, 2024
241ca16
Merge branch 'next' into docs/fix-glob-pattern
naporin0624 Feb 10, 2024
16b2f27
Merge branch 'next' into docs/fix-glob-pattern
naporin0624 Feb 10, 2024
b074b4c
Merge branch 'next' into docs/fix-glob-pattern
naporin0624 Feb 11, 2024
78f122c
simplify error handling, rethrow errors
JReinhold Feb 12, 2024
b7eb433
fix error logging and summary generation
JReinhold Feb 12, 2024
c9e9d62
fix double error logging
JReinhold Feb 12, 2024
57cbc5e
support partial publishing to sandboxes repo
JReinhold Feb 12, 2024
fe7bd93
Merge branch 'next' into docs/fix-glob-pattern
naporin0624 Feb 12, 2024
1e8eaa4
publish based on the presence of a README.md
JReinhold Feb 13, 2024
fce6818
lower fake error threshold
JReinhold Feb 13, 2024
6b1be49
remove fake errors
JReinhold Feb 13, 2024
cea3844
actually remove fake errors 🤦
JReinhold Feb 13, 2024
1c3713e
always cleanup node_modules, don't collapse sandbox logs
JReinhold Feb 13, 2024
01962f3
remove test variables from generate workflow, add job for main
JReinhold Feb 13, 2024
43deb5f
only write summary in CI
JReinhold Feb 13, 2024
d8e40ac
typo
JReinhold Feb 13, 2024
8774d69
Merge branch 'next' into jeppe/25922-ci-generation-of-sandboxes-fail-…
JReinhold Feb 13, 2024
2527e2a
Merge branch 'next' into docs/fix-glob-pattern
naporin0624 Feb 14, 2024
249276b
support new way of mounting components in svelte 5
JReinhold Feb 23, 2024
f37524b
move and cleanup Svelte components
JReinhold Feb 26, 2024
1b17dfe
comment improvements
JReinhold Feb 26, 2024
a3bfcbb
Fix Svelte version check. 🤦
JReinhold Feb 26, 2024
80cb9ec
fix internal unbundled file references
JReinhold Feb 26, 2024
2d5f1f5
pin Svelte 5 version to next.65
JReinhold Feb 26, 2024
b9247ec
add Svelte prerelease sandbox back to CI
JReinhold Feb 26, 2024
982be2d
bring back fix for resetting story args in Svelte 5
JReinhold Feb 26, 2024
d3f533f
Don't expose 'count' state in Button example component as a prop
JReinhold Feb 26, 2024
b6de765
Merge branch 'next' into docs/fix-glob-pattern
naporin0624 Feb 27, 2024
4d24ee0
Resolve vite config from project root instead of cwd
valentinpalkovic Feb 29, 2024
ea40ff8
Handle TypeScript path aliases in react-docgen loader
valentinpalkovic Mar 1, 2024
12495e5
Setup prompt type for automigration
valentinpalkovic Mar 1, 2024
37a59de
Merge branch 'next' into docs/fix-glob-pattern
jonniebigodes Mar 1, 2024
2b48135
Controls: Fix type summary
shilman Mar 2, 2024
2d386cb
Merge branch 'next' into shilman/fix-controls-type-summary
ndelangen Mar 2, 2024
3f766bf
chore: upgrade recast
43081j Mar 2, 2024
f0beb18
Merge pull request #26283 from storybookjs/shilman/fix-controls-type-…
shilman Mar 3, 2024
bb8590c
Add type-safetyness to Fix type
valentinpalkovic Mar 1, 2024
b0f4ab3
Merge pull request #26273 from storybookjs/valentin/support-typescrip…
valentinpalkovic Mar 4, 2024
fbbf22d
Add missing isUpgrade parameter to automigrate function
valentinpalkovic Mar 4, 2024
8909a59
Merge pull request #26262 from storybookjs/valentin/fix-vite-config-a…
valentinpalkovic Mar 4, 2024
7ff80bf
Merge pull request #26293 from storybookjs/valentin/fix-version-check…
valentinpalkovic Mar 4, 2024
9f0bc7d
Add @storybook/addons automigration
valentinpalkovic Mar 4, 2024
eb28dad
Portable stories: Make canvasElement optional in the play function
yannbf Feb 29, 2024
0694772
Update code/lib/preview-api/src/modules/store/csf/portable-stories.te…
yannbf Mar 1, 2024
d39b6c9
use composeConfigs function
yannbf Mar 1, 2024
a289185
update migration notes
yannbf Mar 1, 2024
f60fee3
fix compose configs order
yannbf Mar 1, 2024
2552e03
bring test assertions back
yannbf Mar 1, 2024
40b56a4
use jsx in portable stories react decorator
yannbf Mar 1, 2024
1dd146f
use play function on snapshot tests
yannbf Mar 1, 2024
69e69d1
fix proejct annotation merging logic
yannbf Mar 4, 2024
2b6ce98
Portable stories: Add support for loaders
yannbf Mar 4, 2024
6dae91d
add migration note regarding project annotation overrides
yannbf Mar 4, 2024
43e09f8
Merge branch 'next' into jeppe/svelte-5-prerelease
JReinhold Mar 4, 2024
d7900ad
Merge pull request #26267 from storybookjs/feature/portable-stories-o…
yannbf Mar 4, 2024
c9a26c6
fix the bug and add tests to ensure it doesn't fail ever again
ndelangen Mar 4, 2024
e24a1ee
Merge branch 'next' into norbert/fix-cli-add
ndelangen Mar 4, 2024
8f07e61
fixes
ndelangen Mar 4, 2024
eacdd37
rename for clarity
ndelangen Mar 4, 2024
2d66683
cleanup
ndelangen Mar 4, 2024
be683bf
use hasOwn, which is type-safe, no need for casting
ndelangen Mar 4, 2024
86b27f4
Merge branch 'next' into docs/fix-glob-pattern
jonniebigodes Mar 4, 2024
217c3d0
Merge pull request #25970 from naporin0624/docs/fix-glob-pattern
jonniebigodes Mar 4, 2024
6b0f805
Merge pull request #26188 from storybookjs/jeppe/svelte-5-prerelease
JReinhold Mar 4, 2024
320fd3d
found a flaw thanks to review from valentin
ndelangen Mar 4, 2024
b6b98eb
change package name for test
ndelangen Mar 4, 2024
ba80f3c
Merge pull request #26286 from 43081j/recast-update
shilman Mar 4, 2024
f0a23ca
improve the refs detection
ndelangen Mar 4, 2024
79e976b
Merge branch 'next' into norbert/composition-loading-state-fix
ndelangen Mar 4, 2024
6701349
Merge pull request #26298 from storybookjs/norbert/fix-cli-add
ndelangen Mar 4, 2024
dc07edd
Update minimum Node.js version requirement
valentinpalkovic Mar 5, 2024
4df8934
Merge pull request #26312 from storybookjs/valentin/restrict-usage-of…
valentinpalkovic Mar 5, 2024
02eec68
Merge pull request #26295 from storybookjs/valentin/add-addons-automi…
valentinpalkovic Mar 5, 2024
5b994e7
Merge branch 'next' into norbert/composition-loading-state-fix
ndelangen Mar 5, 2024
7e6438f
fix test
ndelangen Mar 5, 2024
8cbb06d
Merge branch 'norbert/composition-loading-state-fix' of https://githu…
ndelangen Mar 5, 2024
b4a2740
make composeStory in Vue return a component instead of a function
JReinhold Mar 5, 2024
fcd8bf2
fix testing-react import in migration notes
JReinhold Mar 5, 2024
e286d2b
add migration note about new composeStory Vue API
JReinhold Mar 5, 2024
6a0c827
Merge pull request #26013 from storybookjs/jeppe/25922-ci-generation-…
JReinhold Mar 5, 2024
788aaac
add functionality of emitting an event & and test for websocket-trans…
ndelangen Mar 5, 2024
ff54701
fix
ndelangen Mar 5, 2024
2a63d2d
Merge branch 'next' into norbert/ws-disconnect-event
ndelangen Mar 5, 2024
20c596e
Merge pull request #26304 from storybookjs/norbert/composition-loadin…
ndelangen Mar 5, 2024
b709d27
Merge branch 'next' into norbert/ws-disconnect-event
ndelangen Mar 5, 2024
ba64b33
use h helper in vue3 decorators instead, update migration notes
yannbf Mar 5, 2024
6c71508
Merge pull request #26317 from storybookjs/jeppe/compose-vue-api-changes
yannbf Mar 5, 2024
85c4d9c
Merge pull request #26322 from storybookjs/norbert/ws-disconnect-event
shilman Mar 5, 2024
ad2f10d
Write changelog for 8.0.0-rc.2 [skip ci]
storybook-bot Mar 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -706,30 +706,30 @@ workflows:
requires:
- build
- create-sandboxes:
parallelism: 34
parallelism: 35
requires:
- build
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
parallelism: 34
parallelism: 35
requires:
- create-sandboxes
- chromatic-sandboxes:
parallelism: 31
parallelism: 32
requires:
- build-sandboxes
- e2e-production:
parallelism: 29
parallelism: 30
requires:
- build-sandboxes
- e2e-dev:
parallelism: 2
requires:
- create-sandboxes
- test-runner-production:
parallelism: 29
parallelism: 30
requires:
- build-sandboxes

Expand Down
60 changes: 0 additions & 60 deletions .github/workflows/generate-sandboxes-main.yml

This file was deleted.

60 changes: 0 additions & 60 deletions .github/workflows/generate-sandboxes-next.yml

This file was deleted.

127 changes: 127 additions & 0 deletions .github/workflows/generate-sandboxes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
name: Generate and publish sandboxes

on:
schedule:
- cron: "2 2 */1 * *"
workflow_dispatch:
# To test fixes on push rather than wait for the scheduling, do the following:
# 1. Uncomment the lines below and add your branch.
# push:
# branches:
# - <your-branch-name>
# 2. Change the "ref" value to <your-branch-name> in the actions/checkout step below.
# 3. Comment out the whole "generate-main" job starting at line 77
# 4. 👉 DON'T FORGET TO UNDO THE STEPS BEFORE YOU MERGE YOUR CHANGES!

env:
YARN_ENABLE_IMMUTABLE_INSTALLS: "false"
CLEANUP_SANDBOX_NODE_MODULES: "true"

defaults:
run:
working-directory: ./code

jobs:
generate-next:
name: Generate to next
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: next

- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: Setup git user
run: |
git config --global user.name "storybook-bot"
git config --global user.email "32066757+storybook-bot@users.noreply.github.com"

- name: Install dependencies
working-directory: ./scripts
run: node --experimental-modules ./check-dependencies.js

- name: Compile Storybook libraries
run: yarn task --task compile --start-from=auto --no-link

- name: Publish to local registry
run: yarn local-registry --publish

- name: Run local registry
run: yarn local-registry --open &

- name: Wait for registry
run: yarn wait-on tcp:127.0.0.1:6001

- name: Generate
id: generate
run: yarn generate-sandboxes --local-registry

- name: Publish
# publish sandboxes even if the generation fails, as some sandboxes might have been generated successfully
if: ${{ !cancelled() }}
run: yarn publish-sandboxes --remote=https://storybook-bot:${{ secrets.PAT_STORYBOOK_BOT }}@github.com/storybookjs/sandboxes.git --push --branch=next

- name: Report failure to Discord
if: failure()
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_MONITORING_URL }}
uses: Ilshidur/action-discord@master
with:
args: |
The generation of some or all sandboxes on the **next** branch has failed.
[See the job summary for details](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})

generate-main:
name: Generate to main
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: main

- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: Setup git user
run: |
git config --global user.name "storybook-bot"
git config --global user.email "32066757+storybook-bot@users.noreply.github.com"

- name: Install dependencies
working-directory: ./scripts
run: node --experimental-modules ./check-dependencies.js

- name: Compile Storybook libraries
run: yarn task --task compile --start-from=auto --no-link

- name: Publish to local registry
run: yarn local-registry --publish

- name: Run local registry
run: yarn local-registry --open &

- name: Wait for registry
run: yarn wait-on tcp:127.0.0.1:6001

- name: Generate
id: generate
run: yarn generate-sandboxes --local-registry

- name: Publish
# publish sandboxes even if the generation fails, as some sandboxes might have been generated successfully
if: ${{ !cancelled() }}
run: yarn publish-sandboxes --remote=https://storybook-bot:${{ secrets.PAT_STORYBOOK_BOT }}@github.com/storybookjs/sandboxes.git --push --branch=main

- name: Report failure to Discord
if: failure()
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_MONITORING_URL }}
uses: Ilshidur/action-discord@master
with:
args: |
The generation of some or all sandboxes on the **main** branch has failed.
[See the job summary for details](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
16 changes: 16 additions & 0 deletions CHANGELOG.prerelease.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
## 8.0.0-rc.2

- CLI: Add @storybook/addons automigration - [#26295](https://github.com/storybookjs/storybook/pull/26295), thanks [@valentinpalkovic](https://github.com/valentinpalkovic)!
- CLI: Fix vite config automigration to resolve from project root - [#26262](https://github.com/storybookjs/storybook/pull/26262), thanks [@valentinpalkovic](https://github.com/valentinpalkovic)!
- CLI: Improve `add` command & add tests - [#26298](https://github.com/storybookjs/storybook/pull/26298), thanks [@ndelangen](https://github.com/ndelangen)!
- CLI: Update minimum Node.js version requirement - [#26312](https://github.com/storybookjs/storybook/pull/26312), thanks [@valentinpalkovic](https://github.com/valentinpalkovic)!
- CSF-tools/Codemods: Upgrade recast - [#26286](https://github.com/storybookjs/storybook/pull/26286), thanks [@43081j](https://github.com/43081j)!
- Controls: Fix type summary when table.type unset - [#26283](https://github.com/storybookjs/storybook/pull/26283), thanks [@shilman](https://github.com/shilman)!
- Core: Add event when serverChannel disconnects - [#26322](https://github.com/storybookjs/storybook/pull/26322), thanks [@ndelangen](https://github.com/ndelangen)!
- Core: Fix composition of storybooks on same origin - [#26304](https://github.com/storybookjs/storybook/pull/26304), thanks [@ndelangen](https://github.com/ndelangen)!
- Portable stories: Improve existing APIs, add loaders support - [#26267](https://github.com/storybookjs/storybook/pull/26267), thanks [@yannbf](https://github.com/yannbf)!
- React: Handle TypeScript path aliases in react-docgen loader - [#26273](https://github.com/storybookjs/storybook/pull/26273), thanks [@valentinpalkovic](https://github.com/valentinpalkovic)!
- Svelte: Support `5.0.0-next.65` prerelease - [#26188](https://github.com/storybookjs/storybook/pull/26188), thanks [@JReinhold](https://github.com/JReinhold)!
- Upgrade: Add missing isUpgrade parameter to automigrate function - [#26293](https://github.com/storybookjs/storybook/pull/26293), thanks [@valentinpalkovic](https://github.com/valentinpalkovic)!
- Vue: Return component from `composeStory` - [#26317](https://github.com/storybookjs/storybook/pull/26317), thanks [@JReinhold](https://github.com/JReinhold)!

## 8.0.0-rc.1

- CLI: Fix addon compatibility check error reporting in storybook dev - [#26258](https://github.com/storybookjs/storybook/pull/26258), thanks [@yannbf](https://github.com/yannbf)!
Expand Down
Loading
Loading