-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automigration: Run the mdx-to-csf
codemod during automigration
#26201
Conversation
mdx-to-csf
codemod during automigration
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
…m/storybookjs/storybook into norbert/mdx-stories-automigration
Can you please tell me how you have tested this (on which particular project/setup. Then I try to reproduce it)? I followed your testing instructions but the automigration doesn't run. |
@valentinpalkovic the I didn't change that part. I can definitely change that behavior to also check for any existing |
That's not what I mean. I looked into it. Even the check function wasn't executing. The automigration isn't listed in the list of fixes here: https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/automigrate/fixes/index.ts |
WHUT? I used an existing automigration, and it's not listed... |
It was run as part of a codemod. |
Getting the following error when trying to apply the codemod: How to reproduce
(The canary will be available soon: https://github.com/storybookjs/storybook/actions/runs/8067205278) |
OK, verified locally on an sandbox this time. It works |
Closes #26131
What I did
*.stories.mdx
filesmdx-to-csf
codemod during automigrationChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Find a SB6 or SB7 project that uses *.stories.mdx
Upgrade this project to SB8
Expect the *.stories.mdx files to get converted
Expect the main.ts file to be migrated too
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26201-sha-690050fb
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26201-sha-690050fb sandbox
or in an existing project withnpx storybook@0.0.0-pr-26201-sha-690050fb upgrade
.More information
0.0.0-pr-26201-sha-690050fb
norbert/mdx-stories-automigration
690050fb
1709047600
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26201