Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemods: Enhance mdx-to-csf codemod #26164

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Feb 23, 2024

Closes #26140, closes #26130, closes #26146

What I did

  • I have fixed an issue where files were not renamed from .stories.mdx to .mdx although the transformation was successful
  • I have fixed an issue where components doesn't exist in stories.mdx files but a .stories.js file was created
  • The ArgsTable component doesn't exist anymore in Storybook 8.0. The codemod was adjusted to use <Controls /> instead.

Checklist for Contributors

Testing

Unit tests were added, and the codemod was tested on https://github.com/RocketCommunicationsInc/astro/tree/main/packages/web-components. Feel free to test the mdx-to-csf codemod on other heavy-mdx-based 6.x Storybooks.

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26164-sha-8cb78c9f. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26164-sha-8cb78c9f sandbox or in an existing project with npx storybook@0.0.0-pr-26164-sha-8cb78c9f upgrade.

More information
Published version 0.0.0-pr-26164-sha-8cb78c9f
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/enhance-mdx-to-csf-codemod
Commit 8cb78c9f
Datetime Tue Feb 27 11:03:04 UTC 2024 (1709031784)
Workflow run 8063668121

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26164

@valentinpalkovic valentinpalkovic changed the title Valentin/enhance mdx to csf codemod Enhance mdx-to-csf codemod Feb 23, 2024
@valentinpalkovic valentinpalkovic self-assigned this Feb 23, 2024
@valentinpalkovic valentinpalkovic marked this pull request as ready for review February 23, 2024 09:26
@valentinpalkovic valentinpalkovic force-pushed the valentin/enhance-mdx-to-csf-codemod branch 2 times, most recently from 5a95d7f to d2838e2 Compare February 23, 2024 10:43
@valentinpalkovic valentinpalkovic force-pushed the valentin/enhance-mdx-to-csf-codemod branch from d2838e2 to fd8c625 Compare February 23, 2024 10:48
Base automatically changed from valentin/6-to-8-automigrations to next February 27, 2024 14:00
@valentinpalkovic valentinpalkovic changed the title Enhance mdx-to-csf codemod Codemods: Enhance mdx-to-csf codemod Feb 27, 2024
@valentinpalkovic valentinpalkovic merged commit cb4ca53 into next Feb 27, 2024
56 of 57 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/enhance-mdx-to-csf-codemod branch February 27, 2024 14:01
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment