-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codemods: Enhance mdx-to-csf codemod #26164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the title
Valentin/enhance mdx to csf codemod
Enhance mdx-to-csf codemod
Feb 23, 2024
valentinpalkovic
force-pushed
the
valentin/enhance-mdx-to-csf-codemod
branch
2 times, most recently
from
February 23, 2024 10:43
5a95d7f
to
d2838e2
Compare
valentinpalkovic
force-pushed
the
valentin/enhance-mdx-to-csf-codemod
branch
from
February 23, 2024 10:48
d2838e2
to
fd8c625
Compare
This was
linked to
issues
Feb 26, 2024
…dx-to-csf-codemod
kasperpeulen
approved these changes
Feb 27, 2024
valentinpalkovic
changed the title
Enhance mdx-to-csf codemod
Codemods: Enhance mdx-to-csf codemod
Feb 27, 2024
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26140, closes #26130, closes #26146
What I did
.stories.mdx
to.mdx
although the transformation was successfulstories.mdx
files but a.stories.js
file was createdArgsTable
component doesn't exist anymore in Storybook 8.0. The codemod was adjusted to use<Controls />
instead.Checklist for Contributors
Testing
Unit tests were added, and the codemod was tested on https://github.com/RocketCommunicationsInc/astro/tree/main/packages/web-components. Feel free to test the
mdx-to-csf
codemod on other heavy-mdx-based 6.x Storybooks.The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26164-sha-8cb78c9f
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26164-sha-8cb78c9f sandbox
or in an existing project withnpx storybook@0.0.0-pr-26164-sha-8cb78c9f upgrade
.More information
0.0.0-pr-26164-sha-8cb78c9f
valentin/enhance-mdx-to-csf-codemod
8cb78c9f
1709031784
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26164