Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Fix frameworkOptions resolution #25907

Merged

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

The nextConfigPath wasn't resolved correctly. This issue was introduced by #25740 since we forgot to refactor the Next.js code.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a Next.js sandbox
  2. Configure next.config.js in a leaf directory and link it like described here: https://www.npmjs.com/package/@storybook/nextjs#options
  3. Make sure it is loaded (place a console.log in the next.config.js)

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch nextjs ci:normal labels Feb 5, 2024
@valentinpalkovic valentinpalkovic self-assigned this Feb 5, 2024
@valentinpalkovic valentinpalkovic merged commit dda2226 into next Feb 5, 2024
58 of 63 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-framework-options-resolution-nextjs branch February 5, 2024 11:59
shilman pushed a commit that referenced this pull request Feb 6, 2024
…ions-resolution-nextjs

Next.js: Fix frameworkOptions resolution

(cherry picked from commit dda2226)
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
8 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants