Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #2556

Merged
merged 8 commits into from
Dec 24, 2017
Merged

Misc fixes #2556

merged 8 commits into from
Dec 24, 2017

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Dec 24, 2017

What I did

  1. Changed the => to >= as @Hypnosphi pointed here
  2. Add .ts to the .editorconfig

@igor-dv igor-dv self-assigned this Dec 24, 2017
@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #2556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2556   +/-   ##
=======================================
  Coverage   32.69%   32.69%           
=======================================
  Files         398      398           
  Lines        8837     8837           
  Branches      965      955   -10     
=======================================
  Hits         2889     2889           
- Misses       5259     5260    +1     
+ Partials      689      688    -1
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.3% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d8801...37f158b. Read the comment docs.

@Hypnosphi
Copy link
Member

Can you please extract the migration to lodash-es into a separate PR? Looks like it requires some additional jest configuration

@igor-dv
Copy link
Member Author

igor-dv commented Dec 24, 2017

Sure.

@igor-dv igor-dv changed the title Lodash-es and misc fixes Misc fixes Dec 24, 2017
@Hypnosphi Hypnosphi merged commit 8c186be into master Dec 24, 2017
@Hypnosphi Hypnosphi deleted the lodash-es-and-misc-fixes branch December 24, 2017 15:45
@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants