Docs: Adds missing snippets args page #23665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonniebigodes
added
documentation
ci:docs
- Rename snippets to match naming schema - Fix incorrect framing for example - Add disclaimer that globals is probably a better option
kylegach
force-pushed
the
chore_docs_fix_args_snippets
branch
from
a87451d to
50a7d85
Compare
kylegach
added
the
patch:yes
|
@kylegach thanks for taking the time to tweak the text to add some clarification on usage and aligning the snippets. Appreciate it. Merging it now. |
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
Closed
33 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
Merged
14 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Docs: Adds missing snippets args page (cherry picked from commit be7e95f)
kasperpeulen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request the args documentation is updated to fix a couple of missing snippets that were probably accidentally removed here.
Reported here
What I did
@kylegach I've assigned this to you for you to take a look at it. Add any labels and feedback you deem fit to make the snippets available. Appreciate it 🙏
How to test
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>