React: Change StoryFnReactReturnType
to JSX.Element
#23204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
TypeCheck issue whenever we have a decorator like this
Story should return a valid JSX Element to be parsed in the template
What I did
StoryFnReactReturnType was set to ReactElement which is a general term used to refer to the objects that describe React components or HTML tags created using React.createElement() or JSX syntax.
However JSX.Element is a TypeScript type used to define the type of elements returned by JSX expressions,
and that is what StoryFn is actually returning
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]