-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: (Docs) updates testing examples #19757
Conversation
@jonniebigodes Let's discuss this one. It looks like you're updating 7.0 examples back to 6.5 Template style? Is that because we're going to redo all of this in 7.0 anyway? Would it be more appropriate to do a PR directly against |
@jonniebigodes so it's ok to merge this into |
We can merge now and pick it to be released, and I'll continue working on the examples, and once the pr is up, I'll leave the documentation label. |
@jonniebigodes OK, i'm just worried there will be tons of merge conflicts when we bring it back to 6.5. It touches a ton of files. |
@shilman if that's the case, feel free to close this one, and I'll create a branch of the main and base it on that and adjust accordingly and submit the pull request aimed at main. Sounds good? |
Yes, or perhaps you can just try targeting this one into |
I have already a backup of this so no worries there. |
Ok, your call! Thanks & looking forward to the new PR 🙏 |
With this pull request, the documentation is updated to address and close both #19572 and #19703.
What was done:
canvasElement
throughout docs.step
function temporarily from the documentation as based on testing with the latest stable version, it's not working.A follow-up pull request porting the changes over to CSF 3 will be up after this is merged.
@shilman I've assigned this directly to you so that you could take a pass at this and pick it to allow it to be available to the current docs.
Let me know of any feedback. Thanks in advance.