Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to channel that ignores event from self #1879

Merged
merged 4 commits into from
Nov 15, 2017

Conversation

usulpro
Copy link
Member

@usulpro usulpro commented Sep 21, 2017

Issue: #1407
Since we don't check for sender it's hard to know from where the event comes

What I did

Add addPeerListener(type, listener) method, that keeps previous behavior

How to test

yarn jest -- lib/channels/

@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #1879 into release/3.3 will decrease coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1879      +/-   ##
===============================================
- Coverage        21.98%   21.74%   -0.24%     
===============================================
  Files              338      355      +17     
  Lines             6700     7059     +359     
  Branches           880      917      +37     
===============================================
+ Hits              1473     1535      +62     
- Misses            4556     4833     +277     
- Partials           671      691      +20
Impacted Files Coverage Δ
lib/channels/src/index.js 100% <100%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
addons/knobs/src/vue/index.js 23.07% <0%> (-1.07%) ⬇️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 77.96% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e365f8d...c9f21e1. Read the comment docs.

@usulpro usulpro added api: addons maintenance User-facing maintenance tasks labels Sep 22, 2017
@codecov-io
Copy link

codecov-io commented Nov 15, 2017

Codecov Report

Merging #1879 into release/3.3 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1879      +/-   ##
===============================================
+ Coverage        22.74%   22.77%   +0.03%     
===============================================
  Files              326      326              
  Lines             6750     6753       +3     
  Branches           847      843       -4     
===============================================
+ Hits              1535     1538       +3     
- Misses            4603     4604       +1     
+ Partials           612      611       -1
Impacted Files Coverage Δ
lib/channels/src/index.js 100% <100%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/components/src/table/table.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
addons/actions/src/util.js 18.91% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c34ccf...6e73d4a. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 5efd97e into release/3.3 Nov 15, 2017
@Hypnosphi Hypnosphi deleted the channel-onPeer branch November 15, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants